emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Puneeth <punchagan@gmail.com>
To: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: bug: org-narrow-to-subtree
Date: Mon, 1 Nov 2010 19:02:53 +0530	[thread overview]
Message-ID: <AANLkTi=TYXMKAPoNs5_j24VSW0xoQwQQ+0kJbOxGvQWJ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

Hi,

I hit a minor bug with the function org-narrow-to-subtree.

When I narrow to a headline (subtree with just the headline) present
at the end of a file, the last character of the headline isn't present
in the narrowed region. [file1.org and file2.org shown at the end of
the message are examples]

I am attaching a possible patch for the same, but I don't think that
is the "cleanest" way to handle it. Hope it'll help some one else to
fix it in a better way.

Thanks,
Puneeth

file1.org
-----------------
* Hello
* World
* TestEOF
-----------------

file2.org
------------------
* Test
*** World
*** Hello 1EOF
------------------

[-- Attachment #2: org-narrow.patch.txt --]
[-- Type: text/plain, Size: 465 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 59caf41..06b9f9e 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -7501,7 +7501,7 @@ If yes, remember the marker and the distance to BEG."
       (narrow-to-region
        (progn (org-back-to-heading t) (point))
        (progn (org-end-of-subtree t t)
-	      (if (org-on-heading-p) (backward-char 1))
+	      (if (and (org-on-heading-p) (org-at-regexp-p "*")) (backward-char 1))
 	      (point))))))
 
 (eval-when-compile

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

             reply	other threads:[~2010-11-01 13:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-01 13:32 Puneeth [this message]
2010-11-01 18:30 ` bug: org-narrow-to-subtree David Maus
2010-11-01 19:52 ` Carsten Dominik
2010-11-02  3:28   ` Puneeth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=TYXMKAPoNs5_j24VSW0xoQwQQ+0kJbOxGvQWJ@mail.gmail.com' \
    --to=punchagan@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).