emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Michael Brand <michael.ch.brand@gmail.com>
To: David Maus <dmaus@ictsoc.de>
Cc: org-mode <emacs-orgmode@gnu.org>
Subject: Re: IMPORTANT Modified link escaping in Org mode
Date: Sun, 13 Mar 2011 14:37:05 +0100	[thread overview]
Message-ID: <AANLkTi=GW7Uo1HsV08OT6oK8ZD83qLerYMeLJw0NbDF-@mail.gmail.com> (raw)
In-Reply-To: <87k4gysacq.wl%dmaus@ictsoc.de>

Hi David

The current version of dmaus/org-check-percent-escapes from Worg
http://orgmode.org/worg/org-hacks.html#check-old-link-escapes
loops forever in the outer while when used on a one line Org buffer
containing just [[http://www.orgmode.org]] except I hack something
like (goto-char end) behind the inner while. What am I doing wrong?
Did anybody else have this issue?

Michael


On Thu, Feb 17, 2011 at 20:57, David Maus <dmaus@ictsoc.de> wrote:
> Hello everybody,
>
> I've just pushed a series of commits to current master that modifies
> Org modes link escaping functions.
>
> Percent escaping is used in Org mode to escape certain characters in
> links that would either break the parser (e.g. square brackets in link
> target oder description) or are not allowed to appear in a particular
> link type (e.g. non-ascii characters in a http: link).
>
> With this change in place Org will apply percent escaping and
> unescaping more consistently especially for non-ascii characters.
> Additionally some of the outstanding bugs or glitches concerning
> percent escaped links are solved.
>
> However, this change has the potential to break existing links in your
> documents in at least one case: Links that contain a literal percent
> sign followed by two characters in [0-9a-fA-f] might break if this
> sequence of characters is /not/ a percent escape.
>
> E.g. a link to a directory literally called "foo%45bar" will break
> because the new unescaping function will happily interpret the "%45"
> as a percent encoded letter "E".
>
> To detect at least some of such problematic links you can run the
> attached command `dmaus/org-check-percent-escapes' in a Org mode
> buffer.  It will scan all links in the buffer and issue a warning for
> each link that contains a sequence that matches aformentioned pattern
> and is not one of the escape sequences used by Org up to know.
>
> If you experience any problems with this change please don't forget to
> Cc: me so the complaints will end up in my main mailbox.
>
> Best,
>  -- David

  parent reply	other threads:[~2011-03-13 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-17 19:57 IMPORTANT Modified link escaping in Org mode David Maus
2011-02-19 11:11 ` Bastien
2011-02-20 10:34   ` David Maus
2011-02-22 11:21     ` Bastien
2011-03-13 13:37 ` Michael Brand [this message]
2011-03-13 16:04   ` David Maus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=GW7Uo1HsV08OT6oK8ZD83qLerYMeLJw0NbDF-@mail.gmail.com' \
    --to=michael.ch.brand@gmail.com \
    --cc=dmaus@ictsoc.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).