From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathaniel Flath Subject: Re: Re: [PATCH] Alphabetical ordered lists Date: Fri, 26 Nov 2010 20:39:57 -0800 Message-ID: References: <87bp8o498o.fsf@gollum.intra.norang.ca> <393C5110-E4D3-4B36-8F4E-4F94B5AA0F93@gmail.com> <87k4m876g3.wl%n.goaziou@gmail.com> <87iq1r7k00.wl%n.goaziou@gmail.com> <747F5104-6B1C-43E8-BF42-883287B7E303@gmail.com> <87aan0789y.wl%n.goaziou@gmail.com> <874od127wq.wl%n.goaziou@gmail.com> <535BC60F-1310-47AD-BCD1-1C88822B852A@gmail.com> <87y69lqs8z.wl%n.goaziou@gmail.com> <4849E760-2A8F-49A4-9B29-347BD3645D1A@gmail.com> <87r5ep2r0k.wl%n.goaziou@gmail.com> <87bp5hi4qy.wl%n.goaziou@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Received: from [140.186.70.92] (port=52351 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMCZs-0003RD-IR for emacs-orgmode@gnu.org; Fri, 26 Nov 2010 23:40:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PMCZr-0001WM-LQ for emacs-orgmode@gnu.org; Fri, 26 Nov 2010 23:40:00 -0500 Received: from mail-qw0-f41.google.com ([209.85.216.41]:36380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PMCZr-0001WI-IY for emacs-orgmode@gnu.org; Fri, 26 Nov 2010 23:39:59 -0500 Received: by qwh5 with SMTP id 5so437445qwh.0 for ; Fri, 26 Nov 2010 20:39:58 -0800 (PST) In-Reply-To: <87bp5hi4qy.wl%n.goaziou@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Bernt Hansen , Jacob Mitchell , org-mode List , Carsten Dominik I'm working on your comments, should have another patch in the next day or = so. The only thing I had issue with was the comment about org-item-beginning-re: I prefer it as a function for the reasons you mention, but I'm not particularly attached to this. Does anyone else have an opinion? Thanks, Nathaniel Flath On Mon, Nov 22, 2010 at 10:37 AM, Nicolas Goaziou wro= te: > Hello, > >>>>>> Nathaniel Flath writes: > >> although I'm not an expert in the exporting. Let me know if there's >> anything else, or if I screwed up anything when trying to figure out >> how to make a git patch(looks like it worked, though.) > > I looked at your patch and here is what I've noticed so far: > > > - There's a bug in `org-cycle-list-bullet' where > =A0org-list-can-be-alphabetical is called with argument missing. > > - In `org-cycle-list-bullet', variable `top' stores list top point, > =A0make use of it instead of recomputing it. > > - There's a typo in `org-list-parse-list' (ogr-looking-at-p instead of > =A0org-looking-at-p) > > - Some parts of the patch are only white-space changes (for example a > =A0change in `org-list-automatic-rules' but there are others). You > =A0shouldn't include them, as it is not the purpose of the patch. > > =A0It doesn't help understanding your patch either. > > - Why did you remove all code comments about lists in org-docbook.el? > > - This is not a bug but are you sure you want to make > =A0org-item-beginning-re a function? I understand that it permits an > =A0user changing the value of `org-alphabetical-lists' to avoid > =A0reloading Org, but it looks like syntax overweight to me. > > =A0I mean, anyone wanting to look for a list item will have to remember > =A0that it must do a re-search on a function and not a string. > > > Hoping that helps, > > Regards, > > -- Nicolas >