From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Filippo A. Salustri" Subject: Re: question about agendas Date: Thu, 31 Mar 2011 14:58:12 -0400 Message-ID: References: <4239.1301597471@alphaville.usa.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Received: from [140.186.70.92] (port=43664 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5N4Q-0005bc-SX for emacs-orgmode@gnu.org; Thu, 31 Mar 2011 14:58:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5N4P-000134-G4 for emacs-orgmode@gnu.org; Thu, 31 Mar 2011 14:58:14 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:43565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5N4P-00012l-BQ for emacs-orgmode@gnu.org; Thu, 31 Mar 2011 14:58:13 -0400 Received: by wwb39 with SMTP id 39so2764131wwb.30 for ; Thu, 31 Mar 2011 11:58:12 -0700 (PDT) In-Reply-To: <4239.1301597471@alphaville.usa.hp.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: emacs-orgmode@gnu.org Nick, Thanks for the quick reply. I'd actually started with a similar wrapper for org-priority, and the save-excursion was needed because the org-agenda-redo would punt me into the agenda from whatever other buffer I was in. I carried the save-excursion into the agenda version of the function because I thought it couldn't hurt. Apparently it does. Removing the save-excursion from the defun below fixes the cursor problem. ...could it be because the excursion is saved before the agenda buffer is rebuilt? Anyways, it's fixed, so I'm happy. Thanks! Cheers. Fil On 31 March 2011 14:51, Nick Dokos wrote: > Filippo A. Salustri wrote: > >> Hi all, >> I'm looking to customize how some agenda commands work. >> The simple example I'm working on is combining changing a task's >> priority AND refreshing the agenda. >> >> What I'd normally do is: >> 1. cursor to the task of interest, >> 2. change its priority, >> 3. refresh the agenda. >> >> After step 3, the cursor remains where it was in step 2. =A0That's fine. >> >> Then I rebind , in org-agenda-mode-map to this: >> (defun org-fas-agenda-priority (&optional p) >> =A0 "Change the priority of the current item, then refresh agenda." >> =A0 (interactive) >> =A0 (save-excursion >> =A0 =A0 (if (org-agenda-priority p) >> =A0 =A0 =A0 (org-agenda-redo)))) >> >> When this function runs, it does exactly what I want it to do. >> >> BUT the cursor jumps to row one of the agenda buffer. >> >> Can anyone suggest a cause and a fix? >> > > I don't understand it yet, but can you try without the save-excursion > and see if it does what you want? > > Nick > --=20 Filippo A. Salustri, Ph.D., P.Eng. Mechanical and Industrial Engineering Ryerson University 350 Victoria St, Toronto, ON M5B 2K3, Canada Tel: 416/979-5000 ext 7749 Fax: 416/979-5265 Email: salustri@ryerson.ca http://deseng.ryerson.ca/~fil/