From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org, Kelly Dean <kellydeanch@yahoo.com>
Subject: Re: Outline and org-mode don't insert text into folded sections logically
Date: Sun, 30 Oct 2011 16:37:04 +0100 [thread overview]
Message-ID: <A5C4252B-D796-43B7-A164-26944F3204AB@gmail.com> (raw)
In-Reply-To: <87ehxuzw80.fsf@gnu.org>
On 30.10.2011, at 10:04, Bastien wrote:
> Hi Carsten,
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> - This patch covers only one of many ways to make unwanted changes
>> in an invisible area. Others would be delete, backspace,
>> kill-region, yank, kill-line, and an arbitrarily long list of
>> less obvious other commands. Full protection could only be
>> done with pre-change-hooks or so, but would then prevent
>> also programmed changes - something that would not be useful.
>
> Yes, I don't want programmed changes to be affected by this feature.
>
> But having such a warning for `org-delete' would also be useful IMHO.
I guess you mean, org-delete-char and org-delete-backward-char
>
>> `org-self-insert-command' is probably only ever used in an
>> interactive way, so the patch as you have written it may very
>> well function correctly.
>>
>> - All the code in org-self-insert-command is executed for each
>> keypress, so one needs to be careful to have this function
>> carry as little overhead as possible.
>
> I actually think there should be a user option
> `org-edit-invisible-send-warning' defaulting to nil.
+1
>
> The request "don't let me shoot in my foot" is a common
> one, and this option would let people set this to `t'.
>
>> - Currently this chokes at the beginning of the buffer because
>> the invisibility test is also run at (1- (point)).
>
> Fixed, thanks.
>
>> - I am not sure if I understand the positioning code:
>>> (if (or (eq invisible-before-point 'outline)
>>> (eq invisible-before-point 'org-hide-block))
>>> (goto-char (previous-overlay-change (point))))
>>> (org-cycle)
>>> (if (or (eq invisible-before-point 'outline)
>>> (eq invisible-before-point 'org-hide-block))
>>> (forward-char 1))
>>
>> So when I happen to be somewhere in the middle of invisible
>> text and press a character, it seems to me that the character
>> will be inserted at the beginning of the invisible text, and
>> not where the cursor was.
>>
>> Maybe a better solution would be to save point, unfold,
>> go back to point, throw and error and not insert the pressed
>> character. I am not sure, though.
>
> Throwing an error and not inserting the text was what my first
> patch did. I thought it was too restrictive, though.
>
> With an option `org-edit-invisible-send-warning', we could have both:
> `t' would just throw a warning, 'prevent would throw an error.
I like that.
>
>> Maybe you can explain your reasoning?
>
> My reasoning is that, when in the "middle" of an invisible region,
> the user does not know where the point is, hence he doesn't really
> know where he wants to insert characters. In this case, I assume
> insert at the beginning of the invisible region is a reasonable
> default.
I have to admit that it does work well at the end of a folded headline,
and delete-backward-char there would also work fine.
I would think, when the cursor is in the middle of an invisble regions,
the change should always be denied.
Cheers
- Carsten
>
> Thanks for the feedback -- let's continue brainstorming, I think
> this feature is important.
>
> Best,
>
> --
> Bastien
next prev parent reply other threads:[~2011-10-30 15:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 19:14 Outline and org-mode don't insert text into folded sections logically Kelly Dean
2011-09-05 7:52 ` Giovanni Ridolfi
2011-09-05 8:01 ` suvayu ali
2011-10-22 10:13 ` Bastien
2011-10-22 10:17 ` suvayu ali
2011-10-22 10:21 ` Jambunathan K
2011-10-22 13:53 ` Bastien
2011-10-23 2:18 ` suvayu ali
2011-10-29 14:10 ` Bastien
2011-10-29 14:57 ` suvayu ali
2011-10-29 15:40 ` Bastien
2011-10-29 15:53 ` suvayu ali
2011-10-29 16:15 ` Bastien
2011-10-29 16:22 ` suvayu ali
2011-10-30 1:07 ` Bastien
2011-10-30 6:28 ` Carsten Dominik
2011-10-30 7:30 ` Jambunathan K
2011-10-30 7:47 ` Carsten Dominik
2011-10-30 9:04 ` Bastien
2011-10-30 15:37 ` Carsten Dominik [this message]
2011-10-31 20:58 ` Carsten Dominik
2011-11-02 7:12 ` Carsten Dominik
2011-11-02 10:10 ` Bastien
2011-11-02 12:53 ` Carsten Dominik
2011-11-03 1:30 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A5C4252B-D796-43B7-A164-26944F3204AB@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
--cc=kellydeanch@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).