From: Carsten Dominik <carsten.dominik@gmail.com>
To: Sebastian Rose <sebastian_rose@gmx.de>
Cc: emacs-orgmode Mode <emacs-orgmode@gnu.org>,
John Wiegley <jwiegley@gmail.com>
Subject: Re: [PATCH] Remove superfluous lambda.
Date: Tue, 6 Jul 2010 09:44:38 +0200 [thread overview]
Message-ID: <A0EB02B1-994E-4F01-A0F4-C8B7C52C1941@gmail.com> (raw)
In-Reply-To: <87wrtekoj0.fsf@gmx.de>
On Jul 2, 2010, at 3:21 PM, Sebastian Rose wrote:
> David Maus <dmaus@ictsoc.de> writes:
>> Carsten Dominik wrote:
>>> Hmm, the catcher did not see this. Why?
>>
>> He did: http://patchwork.newartisans.com/patch/105/ -- patch is
>> already applied.
>
>
> Where can I see that?
>
>
> I read "Accepted" which is not "Applied", is it?
>
>
> And there are "accepted" patches, that are not "applied".
>
> E.g. http://patchwork.newartisans.com/patch/73/
It is possible that I made a mistake here.
>
>
> The diff against the current head (8da31057eb0952889858c):
>
> diff --git a/lisp/org-capture.el b/lisp/org-capture.el
> index 8c887ce..f38a78c 100644
> --- a/lisp/org-capture.el
> +++ b/lisp/org-capture.el
> @@ -924,6 +924,8 @@ Point will remain at the first line after the
> inserted text."
> (org-capture-put :key (car entry) :description (nth 1 entry)
> :target (nth 3 entry))
> (let ((txt (nth 4 entry)) (type (or (nth 2 entry) 'entry)))
> + (when (file-exists-p txt)
> + (setq txt (org-file-contents txt)))
> (when (or (not txt) (not (string-match "\\S-" txt)))
> ;; The template may be empty or omitted for special types.
> ;; Here we insert the default templates for such cases.
I am rejecting this patch in the current form, because the ambiguity
between file name and template is not good.
I did check in a different patch, where the template may be a sting, or
(file "/path-to-file")
or
(function function-to-make-template)
This should provide more stable and more flexible ways to do this.
- Carsten
>
>
>
> Is it possible to link to the commit a patch was applied?
>
>
>
>
> Sebastian
- Carsten
next prev parent reply other threads:[~2010-07-06 7:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 3:15 org-feed not working for codeproject zwz
2010-06-19 10:48 ` David Maus
2010-06-19 11:29 ` zwz
2010-06-19 14:25 ` [PATCH 0/4] org-feed: Improve feed parsing David Maus
2010-07-01 13:23 ` Carsten Dominik
2010-07-01 18:02 ` [PATCH] Resubmit: Remove superfluous lambda David Maus
2010-07-01 18:02 ` [PATCH] " David Maus
2010-07-02 4:40 ` Carsten Dominik
2010-07-02 6:04 ` David Maus
2010-07-02 13:21 ` Sebastian Rose
2010-07-02 13:23 ` John Wiegley
2010-07-02 13:49 ` Sebastian Rose
2010-07-02 13:53 ` John Wiegley
2010-07-02 13:55 ` Sebastian Rose
2010-07-06 7:44 ` Carsten Dominik [this message]
2010-06-19 14:25 ` [PATCH 1/4] Respect possible XML namespace of rss:item elements David Maus
2010-06-19 14:25 ` [PATCH 2/4] Ignore case of rss element names David Maus
2010-06-19 14:25 ` [PATCH 3/4] Unescape protected entities defined in `xml-entity-alist' David Maus
2010-06-19 14:25 ` [PATCH 4/4] Unescape rss element content David Maus
2010-06-19 14:28 ` [PATCH] Declare variable `xml-entity-alist' for byte compiler David Maus
2010-06-19 14:44 ` [PATCH] Remove superfluous lambda David Maus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A0EB02B1-994E-4F01-A0F4-C8B7C52C1941@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=jwiegley@gmail.com \
--cc=sebastian_rose@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).