From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Re: skip entry with inherited tags Date: Mon, 16 Aug 2010 14:50:33 +0200 Message-ID: References: <20100518074232.GA10524@mteege.de> <4BF2778D.9070702@os.inf.tu-dresden.de> <87mxvxdsv7.fsf@fastmail.fm> <4C082225.6020007@os.inf.tu-dresden.de> <4C08ED73.1000104@os.inf.tu-dresden.de> <4C343FB2.3080204@os.inf.tu-dresden.de> <4C3CA546.3060000@os.inf.tu-dresden.de> <3BFF4D35-CD16-4A41-B0A4-383538586592@gmail.com> <4C3CCDE4.9000600@os.inf.tu-dresden.de> <6694F386-1367-43D6-9587-7F26ECBC9C57@gmail.com> <4C59DDBF.8080105@os.inf.tu-dresden.de> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=52450 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Okz9I-0008RE-Hc for emacs-orgmode@gnu.org; Mon, 16 Aug 2010 08:50:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Okz9C-000395-RU for emacs-orgmode@gnu.org; Mon, 16 Aug 2010 08:50:44 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:40788) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Okz9C-00038u-HM for emacs-orgmode@gnu.org; Mon, 16 Aug 2010 08:50:38 -0400 Received: by eyg7 with SMTP id 7so1408536eyg.0 for ; Mon, 16 Aug 2010 05:50:37 -0700 (PDT) In-Reply-To: <4C59DDBF.8080105@os.inf.tu-dresden.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Martin Pohlack Cc: Matt Lundin , emacs-orgmode@gnu.org On Aug 4, 2010, at 11:38 PM, Martin Pohlack wrote: > Hi Carsten, > > On 22.07.2010 09:38, Carsten Dominik wrote: >> Hi Martin, >> >> On Jul 21, 2010, at 4:32 PM, Carsten Dominik wrote: >> >>> Hi Martin, >>> >>> I just looked at your patch. >>> >>> If I have a normal agenda (i.e. *not* a block agenda), then your >>> patch will cause the preset filter *not* to be applied. >> >> OK, that was obviously incorrect, sorry about that. >> >> However, it still does not work correctly, here is the counter >> example: >> >> ----------------------------------------------------------------------------- >> * TODO test 1 :a: >> * TODO test 2 :b: >> >> * at 1 :a: >> SCHEDULED: <2010-07-22 Thu> >> * at 1 :b: >> SCHEDULED: <2010-07-22 Thu> >> ------------------------------------------------------------------------------ > > Here is what I found to be incorrect. > > * For unmodified org-mode, this ignores the org-agenda-filter-preset. > Is this what you mean or is anything else broken? > > * For my patched version, too much is hidden and only revealed after > clearing the global filter. Did you mean anything else? > >> With this custom command: >> >> (setq org-agenda-custom-commands >> '(("x" "testmartin" >> ((agenda "" ((org-agenda-filter-preset '("+a")))) >> (alltodo "" ((org-agenda-filter-preset '("+b"))))) >> nil nil))) >> >> the result is incorrect, both with and without your patch. > > But in different ways, as state above. Yes, in different ways. > >> The internal logic of the filter and the preset filter is such that >> it applies to the entire view, and you should not set in the local >> options for a command that is part of a block agenda view. > > Well, it is already partly there in that local filters are stored in > text properties for each line. Maybe we can extend this a bit to > remove > this limitation? I think this will be tidious. For block agendas, I guess a skip condition will be better than filtering. Best wishes - Carsten > > I will look into it if I have more time. > > Cheers, > Martin - Carsten