From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rick Frankel Subject: Re: [BUG] Testing fails after rename of ob-sh Date: Fri, 17 Jan 2014 14:01:06 -0500 Message-ID: <9b6933ffd959f5c95b46b0acc46ed0a3@mail.rickster.com> References: <20140116224305.GA45120@eyeBook> <87ha92woah.fsf@Rainer.invalid> <877g9y5wcp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4EfK-0002XW-5d for emacs-orgmode@gnu.org; Fri, 17 Jan 2014 14:01:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W4EfD-0005xf-5m for emacs-orgmode@gnu.org; Fri, 17 Jan 2014 14:01:14 -0500 Received: from mail.rickster.com ([204.62.15.78]:38632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4EfD-0005vn-27 for emacs-orgmode@gnu.org; Fri, 17 Jan 2014 14:01:07 -0500 In-Reply-To: <877g9y5wcp.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: Achim Gratz , emacs-orgmode@gnu.org On 2014-01-17 12:34, Eric Schulte wrote: > Achim Gratz writes: > > What commit were you on before the pull and what branch/commit are you > on now? Also, what's the output of "make config-test" (if you've added > "sh" to BTEST_OB_LANGUAGES, simply remove it). > > > I believe Achim's suggestion should be the correct one. See the > comment > of the commit making this change. > > ,---- > | commit b319475a86451defbdbac064684dd59fd6b0b7d0 > | Author: Eric Schulte > | Date: Fri Dec 13 10:03:05 2013 -0700 > | > | fix tests with the renamed ob-shell.el > | > | Note, users may have to edit their local.mk files to change the > | value of BTEST_OB_LANGUAGES to remove sh and include shell. > `---- Guess I missed that commit message. I looked at the original commit but not the fix. FWIW, I ran it with an clean checkout (but copied my old local.mk), so I guess the issue is that the orginal genaration of local.mk added sh to the list of languages (i never added it manually). I think this is going to bite a lot of people using the master branch. rick