emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rick Frankel <rick@rickster.com>
To: Eric Schulte <schulte.eric@gmail.com>
Cc: Achim Gratz <Stromeko@nexgo.de>, emacs-orgmode@gnu.org
Subject: Re: [BUG] Testing fails after rename of ob-sh
Date: Fri, 17 Jan 2014 14:01:06 -0500	[thread overview]
Message-ID: <9b6933ffd959f5c95b46b0acc46ed0a3@mail.rickster.com> (raw)
In-Reply-To: <877g9y5wcp.fsf@gmail.com>

On 2014-01-17 12:34, Eric Schulte wrote:
> Achim Gratz <Stromeko@nexgo.de> writes:
> 
> What commit were you on before the pull and what branch/commit are you
> on now?  Also, what's the output of "make config-test" (if you've added
> "sh" to BTEST_OB_LANGUAGES, simply remove it).
> 
> 
> I believe Achim's suggestion should be the correct one.  See the 
> comment
> of the commit making this change.
> 
> ,----
> | commit b319475a86451defbdbac064684dd59fd6b0b7d0
> | Author: Eric Schulte <schulte.eric@gmail.com>
> | Date:   Fri Dec 13 10:03:05 2013 -0700
> |
> |     fix tests with the renamed ob-shell.el
> |
> |       Note, users may have to edit their local.mk files to change the
> |       value of BTEST_OB_LANGUAGES to remove sh and include shell.
> `----

Guess I missed that commit message. I looked at the original commit
but not the fix.

FWIW, I ran it with an clean checkout (but copied my old local.mk), so
I guess the issue is that the orginal genaration of local.mk added sh
to the list of languages (i never added it manually).

I think this is going to bite a lot of people using the master branch.

rick

  reply	other threads:[~2014-01-17 19:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 22:43 [BUG] Testing fails after rename of ob-sh Rick Frankel
2014-01-17 13:29 ` Bastien
2014-01-17 16:44 ` Achim Gratz
2014-01-17 17:34   ` Eric Schulte
2014-01-17 19:01     ` Rick Frankel [this message]
2014-01-17 19:27     ` Achim Gratz
2014-01-18 17:26       ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b6933ffd959f5c95b46b0acc46ed0a3@mail.rickster.com \
    --to=rick@rickster.com \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=schulte.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).