emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Dmitry Gorbik <dgorbik@me.com>
To: Bastien <bzg@gnu.org>
Cc: Emacs-orgmode@gnu.org
Subject: Re: Tag setting mode creates two additional windows
Date: Thu, 15 May 2014 04:18:15 -0700	[thread overview]
Message-ID: <9F77CC73-78C1-446F-AC4C-29A309328364@me.com> (raw)
In-Reply-To: <87r43vqqep.fsf@bzg.ath.cx>

[-- Attachment #1: Type: text/plain, Size: 66 bytes --]

This one didn’t work, I modified it like this to make it work:


[-- Attachment #2: tags-split-windows.patch --]
[-- Type: application/octet-stream, Size: 673 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 2661686..5fcacb0 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14877,8 +14877,8 @@ Returns the new tags string, or nil to not change the current settings."
       (if expert
 	  (set-buffer (get-buffer-create " *Org tags*"))
 	(delete-other-windows)
-	(split-window-vertically)
-	(org-switch-to-buffer-other-window (get-buffer-create " *Org tags*")))
+	(set-window-buffer (split-window-vertically) (get-buffer-create " *Org tags*"))
+	(org-switch-to-buffer-other-window " *Org tags*"))
       (erase-buffer)
       (org-set-local 'org-done-keywords done-keywords)
       (org-fast-tag-insert "Inherited" inherited i-face "\n")

[-- Attachment #3: Type: text/plain, Size: 511 bytes --]



Dima

On May 15, 2014, at 3:37 AM, Bastien <bzg@gnu.org> wrote:

> Dmitry Gorbik <dgorbik@me.com> writes:
> 
>> I have found interesting email threads related to exactly same issue.
>> But it looks like it was fixed since then, not sure why it reproduces
>> for me again:
>> 
>> http://lists.gnu.org/archive/html/emacs-orgmode/2010-12/msg00443.html
>> http://article.gmane.org/gmane.emacs.orgmode/34802
> 
> Can you try the attached patch against the master's HEAD?
> 
> <split-window.patch>
> -- 
> Bastien


  reply	other threads:[~2014-05-15 11:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15  8:47 Tag setting mode creates two additional windows Dmitry Gorbik
2014-05-15  8:59 ` Bastien
2014-05-15  9:21   ` Dmitry Gorbik
2014-05-15  9:44     ` Bastien
2014-05-15  9:49       ` Dmitry Gorbik
2014-05-15 10:04         ` Dmitry Gorbik
2014-05-15 10:37           ` Bastien
2014-05-15 11:18             ` Dmitry Gorbik [this message]
2014-05-20 16:21               ` Dmitry Gorbik
2014-05-20 16:56                 ` Bastien
2014-05-20 20:21               ` Bastien
2014-05-21  3:57                 ` Dmitry Gorbik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9F77CC73-78C1-446F-AC4C-29A309328364@me.com \
    --to=dgorbik@me.com \
    --cc=Emacs-orgmode@gnu.org \
    --cc=bzg@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).