From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH 0/2] org-version fix for windows Date: Thu, 20 Aug 2009 20:53:47 +0100 Message-ID: <9D9822BE-2D91-4AFA-BC67-BE4010AE231C@gmail.com> References: <87vdkju8lc.fsf@gollum.intra.norang.ca> <1250712378-16345-1-git-send-email-bernt@norang.ca> <877hwzrvh5.fsf@gollum.intra.norang.ca> <87bpmas3tr.fsf@gollum.intra.norang.ca> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeDht-0007dJ-4G for emacs-orgmode@gnu.org; Thu, 20 Aug 2009 15:53:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeDho-0007cp-G3 for emacs-orgmode@gnu.org; Thu, 20 Aug 2009 15:53:56 -0400 Received: from [199.232.76.173] (port=44209 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeDho-0007cm-Cd for emacs-orgmode@gnu.org; Thu, 20 Aug 2009 15:53:52 -0400 Received: from ey-out-1920.google.com ([74.125.78.148]:49782) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MeDhn-0003fo-UE for emacs-orgmode@gnu.org; Thu, 20 Aug 2009 15:53:52 -0400 Received: by ey-out-1920.google.com with SMTP id 5so81071eyb.24 for ; Thu, 20 Aug 2009 12:53:51 -0700 (PDT) In-Reply-To: <87bpmas3tr.fsf@gollum.intra.norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: Carsten Dominik , emacs-orgmode@gnu.org Applied, thanks - Carsten On Aug 20, 2009, at 8:06 PM, Bernt Hansen wrote: > Hi Carsten, > > As it turns out these patches are okay. Manish retested them on his > system today and they work. > > Please apply. > > Both of these commits are available at git://git.norang.ca/org-mode > for-carsten > > Regards, > Bernt > > PS: Manish> Thanks for testing!! > > Bernt Hansen writes: > >> Carsten, >> >> Please do NOT apply these patches yet. Manish reported a problem >> with >> them on his system. I'll post improved ones tomorrow. >> >> Thanks, >> Bernt >> >> >> Bernt Hansen writes: >> >>> Here are two patches which fix org-version for windows. >>> >>> This should handle cygwin and msysGit where git is installed for use >>> by the default Windows command shell. This does not currently >>> support >>> msysGit where git is not installed in the user's PATH. >>> >>> The series is available at git://git.norang.ca/org-mode for-carsten >>> >>> Bernt Hansen (2): >>> Use lisp cd function to change directories to avoid shell >>> dependencies >>> Skip git-version determination if git command fails >>> >>> lisp/org.el | 42 +++++++++++++++++++++++------------------- >>> 1 files changed, 23 insertions(+), 19 deletions(-)