From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Display invisible entry text at point when visiting a task from the agenda Date: Mon, 3 Jan 2011 13:18:11 +0100 Message-ID: <9B771DE7-EDAA-4222-88C1-19A17792EACF@gmail.com> References: <1293888815-1682-1-git-send-email-bernt@norang.ca> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=50895 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PZjMh-0006do-9z for emacs-orgmode@gnu.org; Mon, 03 Jan 2011 07:18:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PZjMf-0006mN-Ta for emacs-orgmode@gnu.org; Mon, 03 Jan 2011 07:18:19 -0500 Received: from mail-ew0-f41.google.com ([209.85.215.41]:39220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PZjMf-0006mJ-K4 for emacs-orgmode@gnu.org; Mon, 03 Jan 2011 07:18:17 -0500 Received: by ewy27 with SMTP id 27so6863153ewy.0 for ; Mon, 03 Jan 2011 04:18:17 -0800 (PST) In-Reply-To: <1293888815-1682-1-git-send-email-bernt@norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org Applied, thanks. - Carsten On Jan 1, 2011, at 2:33 PM, Bernt Hansen wrote: > * lisp/org-agenda.el (org-agenda-goto): Display invisible entry text > * lisp/org-agenda.el (org-agenda-switch-to): Display invisible entry > text > > Visiting clock lines with RET or TAB in the agenda can put point on a > folded clock drawer. This means you are editing invisible/hidden text > inside the task entry. Now when moving to invisible regions show the > entry so point is always visible. > --- > Hi, > > I regularly visit clock line details from the agenda (C-u l then TAB > or > RET on a clock line or state change log entry line). My clocks and > state changes > are in two separate drawers :CLOCK: and :LOGBOOK: respectively. > > Visiting lines inside drawers are normally folded for me and the > point is > buried in invisible text. > > This patch is available at git://git.norang.ca/org-mode.git agenda- > visit-shows-entry > > Happy New Year all! > > -Bernt > > lisp/org-agenda.el | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index f787240..bf36758 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -6486,7 +6486,9 @@ and by additional input from the age of a > schedules or deadline entry." > (org-show-context 'agenda) > (save-excursion > (and (outline-next-heading) > - (org-flag-heading nil)))) ; show the next heading > + (org-flag-heading nil)))) ; show the next heading > + (when (outline-invisible-p) > + (show-entry)) ; display invisible text > (recenter (/ (window-height) 2)) > (run-hooks 'org-agenda-after-show-hook) > (and highlight (org-highlight (point-at-bol) (point-at-eol))))) > @@ -6672,7 +6674,9 @@ at the text of the entry itself." > (org-show-context 'agenda) > (save-excursion > (and (outline-next-heading) > - (org-flag-heading nil))))))) ; show the next heading > + (org-flag-heading nil))) ; show the next heading > + (when (outline-invisible-p) > + (show-entry)))))) ; display invisible text > > (defun org-agenda-goto-mouse (ev) > "Go to the Org-mode file which contains the item at the mouse > click." > -- > 1.7.4.rc0 > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten