emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: nicholas.dokos@hp.com
Cc: Scott Randby <srandby@gmail.com>, "[Orgmode]" <emacs-orgmode@gnu.org>
Subject: Re: Links and visual-line-mode
Date: Thu, 2 Jun 2011 18:04:46 +0200	[thread overview]
Message-ID: <9AE27AB2-8407-4467-A600-A1EFA6270890@gmail.com> (raw)
In-Reply-To: <20189.1307029869@alphaville.dokosmarshall.org>


On 2.6.2011, at 17:51, Nick Dokos wrote:

> Carsten Dominik <carsten.dominik@gmail.com> wrote:
> 
>>> Yes, with pop-up-windows set to nil, I can reproduce it too.
>>> The problem is that truncate-lines is set to t inside org-insert-link.
>> 
>> Yes, but only after the focus was switched to the *Org Link* buffer which is
>> shown in order to select a link.  truncate-lines is automatically buffer-local,
>> so it should not effect its value in other buffers.  Is truncate-lines modified after inserting a link????
>> 
> 
> Here's what I see with a minimal .emacs and a simple org file (both of them appended):
> 
> - emacs -Q -l minimal.emacs
> - check truncate-lines: it is nil in the foo.org buffer
> - TAB to expand the heading - I get a wrapped line as expected
> - go to the end, C-c C-l foo <RET> bar <RET>
> - by the time of the first <RET> I am back at the foo.org buffer and the line is truncated;
>  checking truncate-lines shows it to be t.

Thanks Nick.  Seems like Emacs is not sure in which
buffer it is at that moment, because it has not yet been displayed.
Could you please try to following paranoid patch?

Thanks.

- Carsten

diff --git a/lisp/org.el b/lisp/org.el
index 1ca03f4..b43a877 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -8889,7 +8889,8 @@ Use TAB to complete link prefixes, then RET for type-specific completion support
 		  (reverse org-stored-links) "\n"))))
       (let ((cw (selected-window)))
 	(select-window (get-buffer-window "*Org Links*" 'visible))
-	(setq truncate-lines t)
+	(with-current-buffer "*Org Links*"
+	  (set (make-local-variable 'truncate-lines) t))
 	(unless (pos-visible-in-window-p (point-max))
 	  (org-fit-window-to-buffer))
 	(and (window-live-p cw) (select-window cw)))



> 
> Nick
> 
> GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.22.0) of 2011-04-13
> Org-mode version 7.5 (baseline.261.g3433)
> 
> minimal.emacs:
> --8<---------------cut here---------------start------------->8---
> ;;; -*- mode: emacs-lisp -*-
> ;;; constant part
> (add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/lisp"))
> (add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" . org-mode))
> (require 'org-install)
> (global-set-key "\C-cl" 'org-store-link)
> (global-set-key "\C-ca" 'org-agenda)
> 
> (setq org-startup-truncated nil)
> (setq pop-up-windows nil)
> (setq-default truncate-lines nil)
> (find-file "~/src/org/visual/scott-randby/foo.org")
> (visual-line-mode 1)
> --8<---------------cut here---------------end--------------->8---
> 
> 
> foo.org:
> --8<---------------cut here---------------start------------->8---
> 
> * foo
> 
> [[foo][bar]]
> bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar bar 
> 
> [[foo][bar]] [[foo][bar]]
> --8<---------------cut here---------------end--------------->8---
> 
> 

  reply	other threads:[~2011-06-02 16:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 23:32 Links and visual-line-mode Scott Randby
2011-06-02  2:49 ` Nick Dokos
2011-06-02  5:30   ` Scott Randby
2011-06-02  5:58     ` Nick Dokos
2011-06-02  6:03       ` Nick Dokos
2011-06-02 14:01       ` Scott Randby
2011-06-02 20:20         ` Sebastien Vauban
2011-06-03 14:24           ` Scott Randby
2011-06-02 14:16       ` Carsten Dominik
2011-06-02 15:51         ` Nick Dokos
2011-06-02 16:04           ` Carsten Dominik [this message]
2011-06-02 16:41             ` Nick Dokos
2011-06-02 17:47               ` Scott Randby
2011-06-02 17:49               ` Carsten Dominik
2011-06-02 19:56                 ` Nick Dokos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9AE27AB2-8407-4467-A600-A1EFA6270890@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=nicholas.dokos@hp.com \
    --cc=srandby@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).