From: Carsten Dominik <carsten.dominik@gmail.com>
To: Mikael Fornius <mfo@abc.se>
Cc: johnw@gnu.org, emacs-orgmode@gnu.org
Subject: Re: [PATCH] (org-habit-build-graph): Help-echo date when mouse is over stars.
Date: Thu, 13 May 2010 07:45:46 +0200 [thread overview]
Message-ID: <9A674B1E-18DB-4B9D-89B2-EC03078AD5C2@gmail.com> (raw)
In-Reply-To: <1272969347-5431-1-git-send-email-mfo@abc.se>
Applied, thanks - sorry this took so long.
- Carsten
On May 4, 2010, at 12:35 PM, Mikael Fornius wrote:
> Hi John, Carsten and fellow orgs.
>
> This patch introduces a small new feature in org-habit I have wanted
> for a while:
>
> When mouse is over a done-star in the habit-graph I get a help-echo
> with the date.
>
> This is useful because I use many preceeding days and there is no easy
> way (that I know of) to find the done-dates when viewing the graph.
> Often I ask myself 'hmm when did I do this habit lately' when I am
> visually evaluating the habit graph and I get stuck, annoying :)
>
> I think this is a small and tasty feature so feel free to use it in
> org-habit if you like it.
>
> ---
> lisp/ChangeLog | 5 +++++
> lisp/org-habit.el | 4 +++-
> 2 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/ChangeLog b/lisp/ChangeLog
> index 7f1a507..a168d73 100644
> --- a/lisp/ChangeLog
> +++ b/lisp/ChangeLog
> @@ -1,3 +1,8 @@
> +2010-05-04 Mikael Fornius <mfo@abc.se>
> +
> + * org-habit.el (org-habit-build-graph): Help-echo date when
> + mouse is over stars.
> +
> 2010-05-02 Dan Davison <davison@stats.ox.ac.uk>
>
> * org-src.el (org-edit-src-code): allow-write-back-p had
> diff --git a/lisp/org-habit.el b/lisp/org-habit.el
> index bb8773e..a3a4d19 100644
> --- a/lisp/org-habit.el
> +++ b/lisp/org-habit.el
> @@ -280,9 +280,11 @@ current time."
> donep)))
> markedp face)
> (if donep
> - (progn
> + (let ((done-time (time-add starting (days-to-time (- start
> (time-to-days starting))))))
> (aset graph index ?*)
> (setq markedp t)
> + (put-text-property index (1+ index) 'help-echo
> + (format-time-string (org-time-stamp-format) done-time) graph)
> (while (and done-dates
> (= start (car done-dates)))
> (setq last-done-date (car done-dates)
> --
> 1.7.1
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
prev parent reply other threads:[~2010-05-13 5:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 10:35 [PATCH] (org-habit-build-graph): Help-echo date when mouse is over stars Mikael Fornius
2010-05-13 5:45 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9A674B1E-18DB-4B9D-89B2-EC03078AD5C2@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=johnw@gnu.org \
--cc=mfo@abc.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).