From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: [Patch] file protocol in HTML links
Date: Thu, 27 May 2010 10:57:41 +0200
Message-ID: <99BD81F0-3064-43B7-9BF9-65EC68802056@gmail.com>
References: <874ohvm2bk.fsf@gmx.de> <87zkznkn2p.fsf@gmx.de>
Mime-Version: 1.0 (Apple Message framework v936)
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=37958 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OHYuV-0004X3-1D
	for emacs-orgmode@gnu.org; Thu, 27 May 2010 04:57:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <carsten.dominik@gmail.com>) id 1OHYuR-0005cq-VC
	for emacs-orgmode@gnu.org; Thu, 27 May 2010 04:57:50 -0400
Received: from mail-fx0-f41.google.com ([209.85.161.41]:39379)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <carsten.dominik@gmail.com>) id 1OHYuR-0005cc-QC
	for emacs-orgmode@gnu.org; Thu, 27 May 2010 04:57:47 -0400
Received: by fxm11 with SMTP id 11so492393fxm.0
	for <emacs-orgmode@gnu.org>; Thu, 27 May 2010 01:57:46 -0700 (PDT)
In-Reply-To: <87zkznkn2p.fsf@gmx.de>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Sebastian Rose <sebastian_rose@gmx.de>
Cc: Emacs-orgmode mailing list <emacs-orgmode@gnu.org>

Hi Sebastian,

can you then please make a patch that reverts the incorrect fix and  
installs your better version?  Against the current master?

Thanks!

- Carsten

On May 26, 2010, at 11:51 AM, Sebastian Rose wrote:

> Sebastian Rose <sebastian_rose@gmx.de> writes:
>> The appended patch removes the protocol part from link URIs, if the
>> protocol is file. Neccessary, to show images again and make links  
>> work.
>>
>>
>> diff --git a/lisp/org-html.el b/lisp/org-html.el
>> index d5f4775..8f7d0f3 100644
>> --- a/lisp/org-html.el
>> +++ b/lisp/org-html.el
>> @@ -640,7 +640,7 @@ MAY-INLINE-P allows inlining it as an image."
>> 	 (setq thefile
>> 	    (let
>> 	       ((str (org-export-html-format-href thefile)))
>> -	       (if type
>> +	       (if (and type (not (string= "file" type)))
>> 		  (concat type ":" str)
>> 		  str)))
>
> Hi,
>
>
> I just pulled and saw it was fixed already - but in a wrong way, I
> believe. How  about an absolute link URL with a different protocol  
> like
> gopher?
>
> I think adding the protocol should be done, if the protocol is  
> different
> from that used to deliver the file which contains the link.
>
> There's no need to add the protocol to an absolute path.
>
>
>
>  Sebastian
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten