From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao-Yong Jin Subject: Re: default face org-column Date: Fri, 28 Jun 2013 13:55:24 +0900 Message-ID: <99A2E7F8-6877-489D-A8C5-3CA51901B4F6@gmail.com> References: <657A219F-8300-4EDD-98B3-6737014F5EF4@gmail.com> <068396FB-493D-456B-922A-D4638EBE0FA3@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_6834BB53-65EC-4F8E-9F80-AB5B5EE987E2" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsQiY-0003Up-15 for emacs-orgmode@gnu.org; Fri, 28 Jun 2013 00:55:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsQiV-0007tp-8v for emacs-orgmode@gnu.org; Fri, 28 Jun 2013 00:55:29 -0400 Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:50315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsQiU-0007tR-WA for emacs-orgmode@gnu.org; Fri, 28 Jun 2013 00:55:27 -0400 Received: by mail-pa0-f41.google.com with SMTP id bj3so1974925pad.14 for ; Thu, 27 Jun 2013 21:55:25 -0700 (PDT) In-Reply-To: <068396FB-493D-456B-922A-D4638EBE0FA3@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: "emacs-orgmode@gnu.org" --Apple-Mail=_6834BB53-65EC-4F8E-9F80-AB5B5EE987E2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jun 1, 2013, at 3:17 PM, Carsten Dominik = wrote: > Hi Xiao, >=20 > I remember that I struggled with the problem that I had to make sure = that column view used a fixed-width face - and this was the solution = that worked - not a particular pretty one, admittedly. >=20 > Do you have an idea on how to change this code that it will always = work? I'd be very happy to accept a good patch. >=20 > - Carsten Hi Carsten, I wasn't sure what you were talking about until I tried out the theme, = leuven... and that was really fanciful and totally screwed the = column-view without your fixed-width face fix. In order to make it more flexible, instead of just set it once when = org-faces.el is loaded, I think enforcing it every time when column-view = is called is a better choice. Thus came the following little patch. diff --git a/lisp/org-colview.el b/lisp/org-colview.el index a98deec..f3b8e42 100644 --- a/lisp/org-colview.el +++ b/lisp/org-colview.el @@ -169,8 +169,10 @@ This is the compiled version of the format.") (get-text-property (point-at-bol) 'face)) 'default)) (color (list :foreground (face-attribute ref-face = :foreground))) - (face (list color 'org-column ref-face)) - (face1 (list color 'org-agenda-column-dateline ref-face)) + (font (list :height (face-attribute 'default :height) + :family (face-attribute 'default :family))) + (face (list color font 'org-column ref-face)) + (face1 (list color font 'org-agenda-column-dateline ref-face)) (cphr (get-text-property (point-at-bol) = 'org-complex-heading-regexp)) pom property ass width f string ov column val modval s2 title = calc) ;; Check if the entry is in another buffer. diff --git a/lisp/org-faces.el b/lisp/org-faces.el index 5472964..e968657 100644 --- a/lisp/org-faces.el +++ b/lisp/org-faces.el @@ -217,12 +217,6 @@ column view defines special faces for each outline = level. See the file "Face for column display of entry properties." :group 'org-faces) =20 -(when (fboundp 'set-face-attribute) - ;; Make sure that a fixed-width face is used when we have a column = table. - (set-face-attribute 'org-column nil - :height (face-attribute 'default :height) - :family (face-attribute 'default :family))) - (defface org-agenda-column-dateline (org-compatible-face 'org-column '((t nil))) In this way, the column-view face will not be bound only to the font = family and size at the time of loading org-faces.el, but anytime = column-view is called. I'm not sure if I covered all the cases, but it = seems to work well for me. I hope the patch is not broken by the mail = app, but I guess it is simple enough to read it in one sip of coffee, = though I tracked the issue and wrote the patch with one cup. Best, Xiao-Yong PS. I realized it was almost a month-old email. Org-mode is really good = at remembering it for me.= --Apple-Mail=_6834BB53-65EC-4F8E-9F80-AB5B5EE987E2 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=windows-1252 carsten.dominik@gmail.com>= ; wrote:
diff --git = a/lisp/org-colview.el b/lisp/org-colview.el
index a98deec..f3b8e42 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -169,8 +169,10 @@ This is the compiled version of = the format.")
    =                     =     (get-text-property (point-at-bol) = 'face))
      =                 =  'default))
    =      (color (list :foreground (face-attribute ref-face = :foreground)))
-     =    (face (list color 'org-column = ref-face))
-     =    (face1 (list color 'org-agenda-column-dateline = ref-face))
+     =    (font (list :height (face-attribute 'default = :height)
+       =              :family (face-attribute = 'default :family)))
+   =      (face (list color font 'org-column = ref-face))
+     =    (face1 (list color font 'org-agenda-column-dateline = ref-face))
      =    (cphr (get-text-property (point-at-bol) = 'org-complex-heading-regexp))
         pom property ass = width f string ov column val modval s2 title = calc)
     ;; = Check if the entry is in another buffer.
diff --git a/lisp/org-faces.el = b/lisp/org-faces.el
index = 5472964..e968657 100644
--- = a/lisp/org-faces.el
+++ = b/lisp/org-faces.el
@@ -217,12 = +217,6 @@ column view defines special faces for each outline level. =  See the file
  =  "Face for column display of entry = properties."
   :group = 'org-faces)
 
-(when = (fboundp 'set-face-attribute)
- =  ;; Make sure that a fixed-width face is used when we have a column = table.
- =  (set-face-attribute 'org-column nil
-               =       :height (face-attribute 'default = :height)
-       =               :family (face-attribute = 'default :family)))
-
 (defface = org-agenda-column-dateline
  =  (org-compatible-face 'org-column
     '((t = nil)))

In this way, the = column-view face will not be bound only to the font family and size at = the time of loading org-faces.el, but anytime column-view is called. =  I'm not sure if I covered all the cases, but it seems to work well = for me.  I hope the patch is not broken by the mail app, but I = guess it is simple enough to read it in one sip of coffee, though I = tracked the issue and wrote the patch with one = cup.

Best,
Xiao-Yong

PS. I realized it was almost a month-old email.  Org-mode is = really good at remembering it for me.
= --Apple-Mail=_6834BB53-65EC-4F8E-9F80-AB5B5EE987E2--