From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH 2/2] Fix broken CUSTOM_ID links Date: Fri, 12 Nov 2010 09:50:06 -0600 Message-ID: <96CFDFB5-67D7-4FF4-901D-00353239DDFC@gmail.com> References: <81mxpnwtah.fsf@gmail.com> <43EFAC24-FD29-4565-AB08-0C6F2AF6CBA5@gmail.com> <81oca0rl2h.fsf_-_@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=53955 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PGvtF-0000QV-04 for emacs-orgmode@gnu.org; Fri, 12 Nov 2010 10:50:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PGvtC-0002l1-5l for emacs-orgmode@gnu.org; Fri, 12 Nov 2010 10:50:11 -0500 Received: from mail-gw0-f41.google.com ([74.125.83.41]:37347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PGvtC-0002km-2K for emacs-orgmode@gnu.org; Fri, 12 Nov 2010 10:50:10 -0500 Received: by gwj16 with SMTP id 16so1806938gwj.0 for ; Fri, 12 Nov 2010 07:50:09 -0800 (PST) In-Reply-To: <81oca0rl2h.fsf_-_@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jambunathan K Cc: emacs-orgmode@gnu.org Hi Jambunata, this looks good, However, I would like you to make a change to the patch more more clarity. Could you please write (or preferred target) instead of remove as the ID to be inserted? Even though these are the same, the first version is a lot clearer. With this change, I will accept the patch. Thanks! - Carsten On Nov 8, 2010, at 7:39 AM, Jambunathan K wrote: > > Carsten > >> On Nov 5, 2010, at 6:53 PM, Jambunathan K wrote: >> >>> >>> Note the 'H:1' in options line. Export this to HTML. Note that >>> CUSTOMID >>> link is broken. A snippet of relevant HTML section is attached >>> below. >>> >>> Change 'H:1' to 'H:3' note that there is no more brokenness. >>> >>> Possible root cause: When headlines are turned to list 'extra- >>> targets' >>> are not identified correctly. >> >> That is correct - Org does not assign IDs or names to list items, >> so it has no place to link to. This could probably be fixed - anyone >> would >> like to fix this? >> > > I am attaching a patch. Hope it does the right thing. > > --- before.html 2010-11-08 19:01:13.796875000 +0530 > +++ after.html 2010-11-08 19:00:57.859375000 +0530 > @@ -7,7 +7,7 @@ > tmp > > > - > + > > > > @@ -101,7 +101,7 @@ > > >