From: Brad Knotwell <bknotwell@yahoo.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-note-abort
Date: Sun, 22 Apr 2018 16:12:24 +0000 (UTC) [thread overview]
Message-ID: <952347247.3665436.1524413544180@mail.yahoo.com> (raw)
In-Reply-To: <87d0ysd76a.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 2607 bytes --]
Good day Nicolas--
I had some time to test your changes (though not fully as I never could figure out how to reproduce getting org-note-abort to stick at 't) and they appear to be working. In doing so, I noticed the following behaviors on the table addition usecase:
* regarding my earlier email that the table row was inconsistently added to the file...I now understand how to make it work consistently. If your "saved point" is *anywhere* in the file up to the start (inclusive) of the last line, your row will be added as you expect. However, if your point is even one character position forward, a new table will be created.* adding a row and aborting it (Ctrl-X Ctrl-K) on aquamacs is always unable to clean itself up in the table case.Thoughts on both issues:
* I thought this might be due to an interaction with desktop mode (or maybe it's aquamacs specific) and that I could workaround it by excluding the target file by customizing desktop-buffers-not-to-save. Unfortunately, that doesn't appear to work and it's possible a code change is necessary.* When things work, this isn't a big deal as you can easily fixup/delete the row yourself. However, when you hit the previous issue, you need to separately edit the file by hand.
Thanks for the fixes.
--Brad On Saturday, April 21, 2018, 6:24:01 AM PDT, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
Hello,
Brad Knotwell <bknotwell@yahoo.com> writes:
> Good day all--
> Earlier, I had written about the unreliability of adding
> a table-line. Well, I ran into a similar problem with the
> (significantly simpler) entry capability. Unlike the table-line, this
> was an easier debug and I determined that org-note-abort was set to
> t which ensures capture will always fail.
> While I don't know exactly how I did it, I suspect it was something
> like the following:* edit a template, test it and find it isn't quite
> what you want* make an (incorrect) change that sets breaks on
> insertion, sets org-note-abort to t and you're stuck until you reset
> it to nil by hand (remarkably, I've had to do the same thing with
> inhibit-trace as well).
> Searching the mailing list and looking at Google hasn't been any more
> illuminating on this. It's important to note that while
> org-capture-kill sets org-note-abort to t, it's reset correctly when
> used in the normal way.
> Version: 9.1.7
> Thx and I'm guessing something similar happened with the table-line
> issue.
I pushed a fix in maint. Could you test it and report if it solves your
issue ?
Regards,
--
Nicolas Goaziou
[-- Attachment #2: Type: text/html, Size: 4098 bytes --]
next prev parent reply other threads:[~2018-04-22 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <371527828.1457872.1523396932915.ref@mail.yahoo.com>
2018-04-10 21:48 ` org-note-abort Brad Knotwell
2018-04-21 13:23 ` org-note-abort Nicolas Goaziou
2018-04-22 16:12 ` Brad Knotwell [this message]
2018-04-29 22:54 ` org-note-abort Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=952347247.3665436.1524413544180@mail.yahoo.com \
--to=bknotwell@yahoo.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).