From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Use backquotes to make byte compiler expand `flet' macro. Date: Mon, 28 Jun 2010 06:29:36 +0200 Message-ID: <94F2D55B-DF77-413A-A885-3FE32D91B9A4@gmail.com> References: <87vd94tta1.fsf@gmail.com> <1277654463-16903-2-git-send-email-dmaus@ictsoc.de> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=48296 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OT5yX-0006eU-UV for emacs-orgmode@gnu.org; Mon, 28 Jun 2010 00:29:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OT5yW-0000Lo-MI for emacs-orgmode@gnu.org; Mon, 28 Jun 2010 00:29:41 -0400 Received: from mail-ww0-f41.google.com ([74.125.82.41]:61984) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OT5yW-0000LY-Gc for emacs-orgmode@gnu.org; Mon, 28 Jun 2010 00:29:40 -0400 Received: by wwf26 with SMTP id 26so2587713wwf.0 for ; Sun, 27 Jun 2010 21:29:38 -0700 (PDT) In-Reply-To: <1277654463-16903-2-git-send-email-dmaus@ictsoc.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: emacs-orgmode@gnu.org Hi David, this is a great solution, thanks. - Carsten On Jun 27, 2010, at 6:01 PM, David Maus wrote: > * org-agenda.el (org-write-agenda): Use backquotes to expand > `flet' at compile time. > --- > lisp/org-agenda.el | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index 8035add..9056206 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -2450,7 +2450,7 @@ higher priority settings." > ((string-match "\\.html?\\'" file) (require 'htmlize)) > ((string-match "\\.ps\\'" file) (require 'ps-print))) > (org-let (if nosettings nil org-agenda-exporter-settings) > - '(save-excursion > + `(save-excursion > (save-window-excursion > (org-agenda-mark-filtered-text) > (let ((bs (copy-sequence (buffer-string))) beg) > @@ -2482,14 +2482,14 @@ higher priority settings." > (message "HTML written to %s" file)) > ((string-match "\\.ps\\'" file) > (require 'ps-print) > - (flet ((ps-get-buffer-name () "Agenda View")) > - (ps-print-buffer-with-faces file)) > + ,(flet ((ps-get-buffer-name () "Agenda View")) > + (ps-print-buffer-with-faces file)) > (message "Postscript written to %s" file)) > ((string-match "\\.pdf\\'" file) > (require 'ps-print) > - (flet ((ps-get-buffer-name () "Agenda View")) > - (ps-print-buffer-with-faces > - (concat (file-name-sans-extension file) ".ps"))) > + ,(flet ((ps-get-buffer-name () "Agenda View")) > + (ps-print-buffer-with-faces > + (concat (file-name-sans-extension file) ".ps"))) > (call-process "ps2pdf" nil nil nil > (expand-file-name > (concat (file-name-sans-extension file) ".ps")) > -- > 1.7.1 > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten