From: Nick Dokos <nicholas.dokos@hp.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Bastien <bzg@altern.org>, Achim Gratz <Stromeko@nexgo.de>,
emacs-orgmode@gnu.org
Subject: Re: remote execution in heterogeneous environment
Date: Fri, 21 Dec 2012 12:32:55 -0500 [thread overview]
Message-ID: <9358.1356111175@alphaville> (raw)
In-Reply-To: Message from Michael Albinus <michael.albinus@gmx.de> of "Fri, 21 Dec 2012 09:24:35 +0100." <87ip7v4xto.fsf@gmx.de>
Michael Albinus <michael.albinus@gmx.de> wrote:
> Bastien <bzg@altern.org> writes:
>
> > Hi Michael,
>
> Hi everybody,
>
> > From the org-mode repo, simply run "make test": it will compile the
> > files and run the test suite.
>
> I could reproduce the problem.
>
> Finally, it is an error in `process-file', which wasn't detected until
> now. Thanks to triggering this!
>
> I've fixed it already in Emacs' trunk. For org-mode, I have used the
> following workaround:
>
> ~/src/org-mode> git diff
> diff --git a/lisp/ob-eval.el b/lisp/ob-eval.el
> index 23e7143..df95d0a 100644
> --- a/lisp/ob-eval.el
> +++ b/lisp/ob-eval.el
> @@ -143,6 +143,11 @@ specifies the value of ERROR-BUFFER."
> shell-file-name
> "/bin/sh"))
> exit-status)
> + ;; There is an error in `process-file', when `error-file' exists.
> + ;; Fixed already in Emacs trunk; for the time being we apply a
> + ;; workaround.
> + (unless (file-remote-p default-directory)
> + (delete-file error-file))
> (if (or replace
> (and output-buffer
> (not (or (bufferp output-buffer) (stringp output-buffer)))))
>
I can confirm that this fixes the local dir case in the simple test I
posted previously (and the remote dir case was fixed by the process-file
fix previously).
> With that workaround, "make test" results in
>
> Ran 320 tests, 319 results as expected, 1 unexpected (2012-12-21 09:13:44+0100)
> 7 expected failures
>
> 1 unexpected results:
> FAILED ob-exp/exports-inline
>
I don't get that failure with the current code, so maybe it has been fixed already (?):
,----
| Ran 334 tests, 334 results as expected (2012-12-21 12:27:17-0500)
| 5 expected failures
`----
Not sure why I have a different number of tests/expected failures either.
But in any case, the main problem is resolved.
Thanks for the fixes!
Nick
next prev parent reply other threads:[~2012-12-21 17:33 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6D36E0F9-01D1-4F95-9FAA-B2B2CA10E57E@gmail.com>
2012-12-18 7:56 ` remote execution in heterogeneous environment Michael Albinus
2012-12-20 13:16 ` Michael Albinus
2012-12-20 16:39 ` Bastien
2012-12-20 16:59 ` Achim Gratz
2012-12-20 17:09 ` Nick Dokos
2012-12-20 17:15 ` Bastien
2012-12-20 17:12 ` Bastien
2012-12-20 20:25 ` Achim Gratz
2012-12-20 17:23 ` Michael Albinus
2012-12-20 17:30 ` Bastien
2012-12-21 8:24 ` Michael Albinus
2012-12-21 8:51 ` Bastien
2012-12-21 17:32 ` Nick Dokos [this message]
2012-12-21 1:21 ` George Jones
2012-12-21 8:27 ` Michael Albinus
2012-12-22 13:32 ` George
2012-12-22 13:36 ` George
2012-12-22 13:48 ` Michael Albinus
[not found] ` <CAOhM7yVOvrL0F8v1hAnxb4z0Mw0kTf6L6_uZk5o7T3W08geUeg@mail.gmail.com>
[not found] ` <CAOhM7yXmD3OEhBt66Ts9YG+8s9LKhkw0-BT0grh734fH07p2pw@mail.gmail.com>
2012-12-23 14:10 ` Michael Albinus
2012-12-23 15:14 ` Bastien
2012-12-23 16:09 ` Michael Albinus
2012-12-23 16:47 ` Bastien
2012-12-23 17:53 ` George Jones
2012-12-23 19:54 ` Bastien
2012-12-23 21:37 ` George Jones
2012-12-24 13:38 ` Michael Albinus
2013-01-07 16:44 ` [BUG] " Achim Gratz
2013-01-08 8:36 ` Michael Albinus
2013-01-08 17:30 ` Achim Gratz
2013-01-08 18:02 ` Eric Schulte
2013-01-08 21:11 ` Michael Albinus
2013-01-09 7:31 ` Achim Gratz
2013-01-09 8:16 ` Michael Albinus
2013-01-09 11:49 ` Bastien
2013-01-09 13:05 ` Michael Albinus
2013-01-09 13:11 ` Bastien
2012-11-29 16:48 Neil Best
2012-11-29 17:05 ` Nick Dokos
2012-11-29 17:16 ` Nick Dokos
2012-11-29 21:48 ` Neil Best
[not found] ` <CANVU8H2wkXN90W+C24t75TDVEctGLqYOYi-H7e86_a2OkFFO8Q@mail.gmail.com>
[not found] ` <11047.1354217134@alphaville>
2012-11-29 22:07 ` Neil Best
2012-11-30 7:37 ` Michael Albinus
2012-11-30 15:33 ` Nick Dokos
2012-11-30 17:12 ` Michael Albinus
2012-11-30 18:24 ` Nick Dokos
2012-11-30 19:13 ` Michael Albinus
2012-11-30 18:02 ` Neil Best
2012-11-30 19:22 ` Michael Albinus
2012-11-30 20:13 ` Neil Best
2012-12-01 9:49 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9358.1356111175@alphaville \
--to=nicholas.dokos@hp.com \
--cc=Stromeko@nexgo.de \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).