From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: org-choose bugfix - whoops Date: Thu, 9 Apr 2009 12:33:59 +0200 Message-ID: <92238960-08A9-4EA8-955C-918F311CFD7B@gmail.com> References: <1158.66.30.184.144.1239235517.squirrel@mail.panix.com> Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: multipart/mixed; boundary="===============1734781248==" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrraC-0006YH-9Z for emacs-orgmode@gnu.org; Thu, 09 Apr 2009 06:34:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lrra7-0006XV-Mb for emacs-orgmode@gnu.org; Thu, 09 Apr 2009 06:34:07 -0400 Received: from [199.232.76.173] (port=46338 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lrra7-0006XS-G8 for emacs-orgmode@gnu.org; Thu, 09 Apr 2009 06:34:03 -0400 Received: from an-out-0708.google.com ([209.85.132.243]:55058) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lrra7-0007fR-4S for emacs-orgmode@gnu.org; Thu, 09 Apr 2009 06:34:03 -0400 Received: by an-out-0708.google.com with SMTP id c38so416737ana.21 for ; Thu, 09 Apr 2009 03:34:02 -0700 (PDT) In-Reply-To: <1158.66.30.184.144.1239235517.squirrel@mail.panix.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Tom Breton (Tehom)" Cc: emacs-orgmode@gnu.org --===============1734781248== Content-Type: multipart/alternative; boundary=Apple-Mail-1--1026965542 --Apple-Mail-1--1026965542 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Hi Tom, On Apr 9, 2009, at 2:05 AM, Tom Breton (Tehom) wrote: > My previous fix was mistaken. Not sure why it passed tests; I > have two theories. Regardless, it was wrong. Current > `(org-outline-level)' seems the correct "LEVEL=" matcher argument to > make `org-map-entries' find only an item's immediate children. > (Operated > on by `org-reduced-level' of course) I don't quite understand why. > > Second, I may have solved the mystery of how the bug got by me before. > `org-map-entries' used to place point at the beginning of an item, a > fact which I used to recognize visiting the same item. That seems to > have changed between org versions. > > Third, I have fixed the real bug - properly now, I hope! - and > attached a patch. I have applied the patch. Indeed, there was a problem with the cursor positioning during mapping, but I think this should be fixed again. Really, I want the cursor at the beginning of the entry when the mapping function is called. So maybe you'd like to pull from git, check again, and revert the change? I believe that the back-to-heading wrapper will not hurt, but I also believe it is no longer necessary. My apologies for the mess. - Carsten --Apple-Mail-1--1026965542 Content-Type: text/html; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Tom,

On = Apr 9, 2009, at 2:05 AM, Tom Breton (Tehom) wrote:

My previous fix was mistaken. Not sure why it = passed tests; I
have two theories. Regardless, it was wrong. = Current
`(org-outline-level)' seems the correct "LEVEL=3D" = matcher argument to
make `org-map-entries' find only an item's = immediate children. (Operated
on by `org-reduced-level' of = course) I don't quite understand why.

Second, I may have = solved the mystery of how the bug got by me before.
`org-map-entries' = used to place point at the beginning of an item, a
fact which I used = to recognize visiting the same item. That seems to
have changed = between org versions.

Third, I have fixed the real bug - properly = now, I hope! - and
attached a = patch.

I have applied the = patch.

Indeed, there was a problem with the = cursor positioning during mapping,

but I think this should be = fixed again. Really, I want the cursor at

the beginning = of the entry when the mapping function is = called.

So maybe you'd like to pull from git, = check again, and revert the change?

I believe that the = back-to-heading wrapper will not hurt, but I also believe

it = is no longer necessary.

My apologies for the = mess.

- = Carsten

= --Apple-Mail-1--1026965542-- --===============1734781248== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============1734781248==--