emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: "Tom Breton (Tehom)" <tehom@panix.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-choose bugfix - whoops
Date: Thu, 9 Apr 2009 12:33:59 +0200	[thread overview]
Message-ID: <92238960-08A9-4EA8-955C-918F311CFD7B@gmail.com> (raw)
In-Reply-To: <1158.66.30.184.144.1239235517.squirrel@mail.panix.com>


[-- Attachment #1.1: Type: text/plain, Size: 1206 bytes --]

Hi Tom,

On Apr 9, 2009, at 2:05 AM, Tom Breton (Tehom) wrote:

> My previous fix was mistaken.  Not sure why it passed tests; I
> have two theories.  Regardless, it was wrong.  Current
> `(org-outline-level)' seems the correct "LEVEL=" matcher argument to
> make `org-map-entries' find only an item's immediate children.   
> (Operated
> on by `org-reduced-level' of course)  I don't quite understand why.
>
> Second, I may have solved the mystery of how the bug got by me before.
> `org-map-entries' used to place point at the beginning of an item, a
> fact which I used to recognize visiting the same item.  That seems to
> have changed between org versions.
>
> Third, I have fixed the real bug - properly now, I hope! - and
> attached a patch.

I have applied the patch.

Indeed, there was a problem with the cursor positioning during mapping,
but I think this should be fixed again.  Really, I want the cursor at
the beginning of the entry when the mapping function is called.

So maybe you'd like to pull from git, check again, and revert the  
change?
I believe that the back-to-heading wrapper will not hurt, but I also  
believe
it is no longer necessary.

My apologies for the mess.

- Carsten


[-- Attachment #1.2: Type: text/html, Size: 1619 bytes --]

[-- Attachment #2: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

      reply	other threads:[~2009-04-09 10:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-09  0:05 org-choose bugfix - whoops Tom Breton (Tehom)
2009-04-09 10:33 ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92238960-08A9-4EA8-955C-918F311CFD7B@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=tehom@panix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).