From: Carsten Dominik <carsten.dominik@gmail.com>
To: Tassilo Horn <tassilo@member.fsf.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Bug] Slightly wrong org-tag fontification in agenda
Date: Fri, 12 Feb 2010 18:58:29 +0100 [thread overview]
Message-ID: <92220325-DA7F-4020-9666-35CE689C3439@gmail.com> (raw)
In-Reply-To: <87d40a8u7o.fsf@thinkpad.tsdh.de>
Hi Tassilo,
On Feb 12, 2010, at 2:22 PM, Tassilo Horn wrote:
> Hi all,
>
> it seems that org fontifies everything in the agenda following the
> heading using the org-tag face. Basically, that's ok *unless* you
> don't
> use a special background color for tags. Then it looks wrong.
>
> Here's a screenshot showing the fontification.
> <org-tags.png>
> I'm using a current git version (Org-mode version 6.34trans
> (release_6.34c.67.g25f76f)).
>
> I had a quick look at the code, and it seems the problem is in
> `org-agenda-align-tags'.
Yes, I think it is fixed now.
>
> BTW: Is it really a good decision to propertize the text
> algorithmically
> in the functions building the agenda? I'm not sure, but it might be
> easier to define some `org-agenda-font-lock-keywords' like it's done
> for
> org files, too.
That is a good question. I do, however, not believe that it would
be easy to define font lock keywords which can handle the agenda.
For example, when an item changes state, its face is changed, to
something with depends on where the item comes from and, for example,
how close the deadline is. And more stuff like that.
So font-lock regexp matching is now enough here.
Yes, it would be enough for tags, but not for other stuff.
- Carsten
next prev parent reply other threads:[~2010-02-12 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 13:22 [Bug] Slightly wrong org-tag fontification in agenda Tassilo Horn
2010-02-12 17:58 ` Carsten Dominik [this message]
2010-02-12 19:29 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92220325-DA7F-4020-9666-35CE689C3439@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=tassilo@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).