From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vladimir Panteleev <thecybershadow@gmail.com>
Subject: Re: [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in
 arguments
Date: Tue, 13 Mar 2018 19:16:57 +0000
Message-ID: <9107300b-c95d-ad16-ca03-088d173c90d9@gmail.com>
References: <20180307225847.24068-1-git@thecybershadow.net>
	<20180307225847.24068-2-git@thecybershadow.net>
	<87muzcans9.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34730)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thecybershadow@gmail.com>) id 1evpQ1-0002IK-Aa
	for emacs-orgmode@gnu.org; Tue, 13 Mar 2018 15:17:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thecybershadow@gmail.com>) id 1evpPy-0002aB-3x
	for emacs-orgmode@gnu.org; Tue, 13 Mar 2018 15:17:05 -0400
Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]:34315)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <thecybershadow@gmail.com>)
	id 1evpPx-0002ZB-U8
	for emacs-orgmode@gnu.org; Tue, 13 Mar 2018 15:17:02 -0400
Received: by mail-wr0-x229.google.com with SMTP id o8so2091905wra.1
	for <emacs-orgmode@gnu.org>; Tue, 13 Mar 2018 12:17:01 -0700 (PDT)
In-Reply-To: <87muzcans9.fsf@nicolasgoaziou.fr>
Content-Language: en-US
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>, Vladimir Panteleev <git@thecybershadow.net>
Cc: emacs-orgmode@gnu.org

Hi,

On 2018-03-12 23:15, Nicolas Goaziou wrote:
> The dollar character looks strange. What syntax is that?

I agree that it is strange. I mentioned it (and its strangeness) in the 
cover-letter. The documentation of org-sbe describes it as well.

>> +#+name: identity
>> +#+begin_src emacs-lisp :eval yes
>> +  x
>> +#+end_src"
>> +    (should (equal "a\"b\"c"
>> +		   (eval '(org-sbe identity (x $ "a\"b\"c")))))))
> 
> Why `eval'? Why not simply (org-sbe identity (x ...)) ?

Ah, I guess that's another "funny" thing about org-sbe that I forgot to 
mention. It is a macro, but it does some things that are rather 
non-macro-y. In this case, eval is required, otherwise it will attempt 
to parse the Org document during Lisp *compilation*, and you will see:

Eager macro-expansion failure: (error "Reference ‘identity’ not found in 
this buffer")
Eager macro-expansion failure: (error "Reference ‘identity’ not found in 
this buffer")
Reference ‘identity’ not found in this buffer

-- 
Best regards,
  Vladimir