From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [PATCH] contrib: ob-sclang: Fix compilation issue. Date: Sun, 25 Mar 2018 10:38:01 +0800 Message-ID: <8ee2f38d-40f9-e706-4fcd-a2e2b0855a79@gmail.com> References: <878tahvytr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------B6645B721BB600F908E59EB6" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezvXv-0007W1-Pd for emacs-orgmode@gnu.org; Sat, 24 Mar 2018 22:38:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezvXr-0007Oy-Q9 for emacs-orgmode@gnu.org; Sat, 24 Mar 2018 22:38:11 -0400 Received: from mail-pf0-x236.google.com ([2607:f8b0:400e:c00::236]:45160) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezvXr-0007OV-Jf for emacs-orgmode@gnu.org; Sat, 24 Mar 2018 22:38:07 -0400 Received: by mail-pf0-x236.google.com with SMTP id l27so6184438pfk.12 for ; Sat, 24 Mar 2018 19:38:07 -0700 (PDT) Received: from [0.0.0.0] ([119.28.89.243]) by smtp.gmail.com with ESMTPSA id z21sm19502346pge.42.2018.03.24.19.38.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Mar 2018 19:38:04 -0700 (PDT) In-Reply-To: <878tahvytr.fsf@gmail.com> Content-Language: en-US List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org This is a multi-part message in MIME format. --------------B6645B721BB600F908E59EB6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi, @MaximI'm the author of `ob-sclang.el`. Whyneed to require `sclang` instead of `sclang-interp`? ob-sclangused functions are all in `sclang-interp.el` file. No need to require `sclang`. And I checked out `scel` source code, have not found update. Might because `sclang-interp`? On 03/25/2018 07:27 AM, Maxim Cournoyer wrote: > Hello! > > The attached patch fixes a byte compilation issue in ob-sclang.el. > > Thank you! > > Maxim > --------------B6645B721BB600F908E59EB6 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi, @Maxim I'm the author of `ob-sclang.el`.

Why need to require `sclang` instead of `sclang-interp`? ob-sclang used functions are all in `sclang-interp.el` file. No need to require `sclang`. And I checked out `scel` source code, have not found update.

Might because `sclang-interp`?

On 03/25/2018 07:27 AM, Maxim Cournoyer wrote:

Hello!

The attached patch fixes a byte compilation issue in ob-sclang.el.

Thank you!

Maxim

--------------B6645B721BB600F908E59EB6--