From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6KWRDfVxTGIHQwEAgWs5BA (envelope-from ) for ; Tue, 05 Apr 2022 18:44:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SNmDCvVxTGIGDwEAauVa8A (envelope-from ) for ; Tue, 05 Apr 2022 18:44:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CD73213CE3 for ; Tue, 5 Apr 2022 18:44:36 +0200 (CEST) Received: from localhost ([::1]:46072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbmIF-0002Pv-Tj for larch@yhetil.org; Tue, 05 Apr 2022 12:44:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbmHi-0002Pc-Jv; Tue, 05 Apr 2022 12:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbmHi-0000iN-93; Tue, 05 Apr 2022 12:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbmHh-0000M5-NQ; Tue, 05 Apr 2022 12:44:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#54731: Please, revert part of dd0727e1ec1 related to Org mode (`encode-time') Resent-From: Max Nikulin Original-Sender: "Debbugs-submit" Resent-CC: emacs-orgmode@gnu.org, eggert@cs.ucla.edu, bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Apr 2022 16:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 54731@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: emacs-orgmode@gnu.org, eggert@cs.ucla.edu Received: via spool by submit@debbugs.gnu.org id=B.16491770251312 (code B ref -1); Tue, 05 Apr 2022 16:44:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Apr 2022 16:43:45 +0000 Received: from localhost ([127.0.0.1]:55984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbmHR-0000L5-0G for submit@debbugs.gnu.org; Tue, 05 Apr 2022 12:43:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:33596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbmHP-0000Kx-HY for submit@debbugs.gnu.org; Tue, 05 Apr 2022 12:43:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbmHP-0002PA-Aj for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 12:43:43 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:39722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbmHM-0000gz-PJ for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 12:43:42 -0400 Received: by mail-lf1-x132.google.com with SMTP id y32so8989414lfa.6 for ; Tue, 05 Apr 2022 09:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:from:to :content-language:subject:content-transfer-encoding; bh=0CIToLgFS1WcDgRi8HjIhd6u7C6C8JBW4Gbo/osV3cg=; b=K+6J+PVhbQ/dl+2FroEPUTh3gxPgWcKsqtFfE4lcvFLsBU+4dY9kfOxMnMDmrStsu/ 5fVocvkFCM46L2MQkkYx4iE9O1ucmdoAqzU+YVXqYNLZt7CtZZYxjsBqFsKQ+Pa1f1GU BPcsbl5n6VsCS0AX6gIx40McEnLJdAPtoGVHLxfNFOdCoYsgsLcm0k6YmiyXPFCjdJnA XjwtPW9hXvdKeBKazbbDuAUuQgQhgyC86ovLJOaBuIc2Ue+kE6YHwzRgediRFQAZs+8A luiAib4qJZYFPUSLwkRQmW3RZ5iO60iWRT35pD+IFG8GVU85ikpr+gjQtaAdILIzMZRQ S+pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :from:to:content-language:subject:content-transfer-encoding; bh=0CIToLgFS1WcDgRi8HjIhd6u7C6C8JBW4Gbo/osV3cg=; b=UKtOJOiSwhvznuY6U9UyDiN1fvq2CWRI3YswFhAOURqHqjs38tAJ7FmnVIqz8FAIwn tUNo1FrA4sauQ6ls62RxHa5nC834jiT8uMIHdZeztDD/DwSXpbwFxPj6KCmf2VypJ4Nk wpLsK+18ZNbdNeHTVyhSSzJD10YjghlLbUL6bi2vUu5if+7LGsHGBV9vmpNxsqTxUXsA O3yeHO/Jj8kTGjtGqVG5+2RQ87A9FQVNEsOs2W/kz1lMgGseTvlXWrMGoTGgoTD7aQVu IDttIyCA6bAGfMEFK+ASMQpvLbmbAfx92fm/mvBuBGtKWiZ5xuGt6EFMtiJ/6p7+8llr Lp+Q== X-Gm-Message-State: AOAM531BaY7sSg9z4cRHkkLfbGh0NaGwzqSitD7mUi42tnDxWnsYprUK nEGnKCL6obWqlH+lDOAbVIp7Z/FE8sw= X-Google-Smtp-Source: ABdhPJx+Nrh40KhOAis0S2hObfZNQtq6/OeDzHUxIkbSOrYn1hk35k6byi4lbAX57a17+dt3l6PTsA== X-Received: by 2002:a05:6512:230c:b0:44a:2282:8e38 with SMTP id o12-20020a056512230c00b0044a22828e38mr3235010lfu.315.1649177017423; Tue, 05 Apr 2022 09:43:37 -0700 (PDT) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id n15-20020a196f4f000000b0044a15076333sm1550800lfk.71.2022.04.05.09.43.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Apr 2022 09:43:36 -0700 (PDT) Message-ID: <8b85c879-4f9b-eac3-e700-f176cc588577@gmail.com> Date: Tue, 5 Apr 2022 23:43:35 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 From: Max Nikulin Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::132; envelope-from=manikulin@gmail.com; helo=mail-lf1-x132.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: emacs-orgmode@gnu.org List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eggert@cs.ucla.edu, emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649177076; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=0CIToLgFS1WcDgRi8HjIhd6u7C6C8JBW4Gbo/osV3cg=; b=hP0QMBHC5qmZboSNcyKX2qHchGOi0xgmFTHfjEEYpxuBjzpnnI6ENgZ0gR8jFDJS6OfFzz UaTgnoP/V/bW1ABAKHxPSmTRgxeOyEIGEO4Zl+ubgWkzqyWgA7gW4+Vq/368TrUS9aClem 8A5KoesXjrLoBEZt48ics+MWJKDTBXPzt1X2TssCl6seOgE0tybtwGBo7XM5y7zQ8UbGWM VWBt7pm/aHWs2vTRfzBdPeobadEVrzzgOBIzIGYDcPxuqchEEQvuwyx6+B9KMpPBJh4nio szvrTxRB9A3Of/q1u6D2sgulmyOQBiJIASthdoQqHSUM3tZ6FkwrTyLdaJiosg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649177076; a=rsa-sha256; cv=none; b=i6i8lO/SLlIN7vaZig6Nxh8HzCzZ9dc3TaL8O7NtN2LXQau8MXlCHiC+aCXjSEEIBFRUiU JD/wmN9mXG5nD46fMakzCC0vvfmsZYjX7ZKUECfg8bXboJ76iz7QXARURfovrryHH+XxVM LjngOBqEKJGhh51jlQOsAYfO4Hn+3811fu16R+frQrMFZoiS5divt7CSzHqrqdC0WreRV9 LK+JL02eALXcKkZVk91CbO4VoO1DkWVE1BOtcb8iTzri/bwjVB1zGqzXjaWDCPexB66q2E kIyRNGbb7TYNIiyl6GB33DUmxCKhNUrqlg1S0RQD0dBRP1KmhfcEcT0gxH7BPw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=K+6J+PVh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=K+6J+PVh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CD73213CE3 X-Spam-Score: 5.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: wOwkz5Zu3UWn Recently a bug with daylight saving time has been reported to the Org mode mail list: https://list.orgmode.org/PAXPR06MB7760238F410CBE3203F78EE0C61E9@PAXPR06MB7760.eurprd06.prod.outlook.com Ignacio Casso. [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day. Tue, 29 Mar 2022 15:09:10 +0200. It can be reproduced only with the Org version bundled with Emacs-29. The code from the Org git repository works correctly. Due to Emacs commit dd0727e1ec1 Paul Eggert Thu Dec 16 09:40:21 2021 -0800 encode-time simplifications code of Org in the Emacs and the Org repositories diverged. Changes can not be just committed to Org since Org as a standalone package is compatible with Emacs-26 and even still with Emacs-25 where new style of `encode-time' arguments are not supported. Moreover daylight saving time flag is ignored when timestamp components are passed as separate arguments and some Org code uses nil value (no DST) instead of -1 (ignore DST). Even within Emacs both old and new calling styles of `encode-time' are used, so partial revert of the change does not reduce code consistency significantly enough. On the Org side it is necessary to update at least the `org-parse-time-string' function and to introduce a compatibility wrapper that will use old calling convention when running under old Emacs versions. Such changes should finally land in the Emacs repository as well. Please, revert changes from dd0727e1ec1 related to Org to fix the daylight saving time and to mitigate merge conflicts during porting of future fixes in Org. Notice, this bug is namely for Emacs, not for Org mode as debbugs packages.