From: Max Nikulin <manikulin@gmail.com>
To: 54731@debbugs.gnu.org
Cc: eggert@cs.ucla.edu, emacs-orgmode@gnu.org
Subject: bug#54731: Please, revert part of dd0727e1ec1 related to Org mode (`encode-time')
Date: Tue, 5 Apr 2022 23:43:35 +0700 [thread overview]
Message-ID: <8b85c879-4f9b-eac3-e700-f176cc588577@gmail.com> (raw)
Recently a bug with daylight saving time has been reported to the Org
mode mail list:
https://list.orgmode.org/PAXPR06MB7760238F410CBE3203F78EE0C61E9@PAXPR06MB7760.eurprd06.prod.outlook.com
Ignacio Casso. [BUG] org-agenda thinks timestamps after 23:00 correspond
to the next day. Tue, 29 Mar 2022 15:09:10 +0200.
It can be reproduced only with the Org version bundled with Emacs-29.
The code from the Org git repository works correctly. Due to Emacs
commit dd0727e1ec1
Paul Eggert Thu Dec 16 09:40:21 2021 -0800 encode-time simplifications
code of Org in the Emacs and the Org repositories diverged. Changes can
not be just committed to Org since Org as a standalone package is
compatible with Emacs-26 and even still with Emacs-25 where new style of
`encode-time' arguments are not supported.
Moreover daylight saving time flag is ignored when timestamp components
are passed as separate arguments and some Org code uses nil value (no
DST) instead of -1 (ignore DST).
Even within Emacs both old and new calling styles of `encode-time' are
used, so partial revert of the change does not reduce code consistency
significantly enough.
On the Org side it is necessary to update at least the
`org-parse-time-string' function and to introduce a compatibility
wrapper that will use old calling convention when running under old
Emacs versions. Such changes should finally land in the Emacs repository
as well.
Please, revert changes from dd0727e1ec1 related to Org to fix the
daylight saving time and to mitigate merge conflicts during porting of
future fixes in Org.
Notice, this bug is namely for Emacs, not for Org mode as debbugs packages.
next reply other threads:[~2022-04-05 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 16:43 Max Nikulin [this message]
2022-04-06 0:56 ` bug#54731: Please, revert part of dd0727e1ec1 related to Org mode (`encode-time') Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b85c879-4f9b-eac3-e700-f176cc588577@gmail.com \
--to=manikulin@gmail.com \
--cc=54731@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).