From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Change C-' behaviour on #+TBLFM: line Date: Sat, 20 Nov 2010 12:34:20 +0100 Message-ID: <8AA18220-AFCA-42B6-A15B-D88D2F58A2D9@gmail.com> References: <4CE63A34.9060606@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=54368 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJli7-0006vS-Ib for emacs-orgmode@gnu.org; Sat, 20 Nov 2010 06:34:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJli5-0004qf-Sw for emacs-orgmode@gnu.org; Sat, 20 Nov 2010 06:34:26 -0500 Received: from mail-ew0-f41.google.com ([209.85.215.41]:64344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJli5-0004qV-Nm for emacs-orgmode@gnu.org; Sat, 20 Nov 2010 06:34:25 -0500 Received: by ewy25 with SMTP id 25so3244376ewy.0 for ; Sat, 20 Nov 2010 03:34:25 -0800 (PST) In-Reply-To: <4CE63A34.9060606@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Torsten Wagner Cc: emacs-orgmode@gnu.org Hi Torsten, applied with minor changes. Thanks! - Carsten On Nov 19, 2010, at 9:49 AM, Torsten Wagner wrote: > Hi, > > Short description: > > I recently started to use tables in org-mode. Having the pointer > inside > the the table and pressing C-c' I can enter the formula buffer. > However, placing the pointer on the #+TBLFM: line C-c' results in > "Find > file or URL:". > > If even more people believe this is confusing, I would suggest to > switch > the behaviour. C-c' on a #+TBLFM: line should open up the formular > buffer. > > Longer Explanation: > > For small changes of the formula I often edit the #+TBLFM: line > directly. If things went more complex or get messed, I press C-c' to > enter the formula buffer. However, at this time my pointer is > located at > the #+TBLFM: line. > > The associated call function for C-c' is: > > org-edit-special > > This function calls > > org-table-edit-formulas > > in case the point is located inside the table and > > ffap aka find-file-at-point > > in all other cases (omitting the cases for source code and include > lines > here for simplicity) > > Thus pressing C-c' at #+TBLFM ends up with the request for a file or > a URL. > > In my opinion org-edit-special needs another case to look out for > #+TBLFM or resp. combine this with the case to call > `org-table-edit-formulas'. > > Please find below a patch for that. > > -------patch--------begin-------- > > diff --git a/lisp/org.el b/lisp/org.el > index 023e019..a7e4d33 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -17259,7 +17259,9 @@ When in an #+include line, visit the include > file. Otherwise call > ((org-edit-fixed-width-region)) > ((org-at-table.el-p) > (org-edit-src-code)) > - ((org-at-table-p) > + ((or (org-at-table-p) (save-excursion > + (beginning-of-line 1) > + (looking-at "[ \t]*#\\+TBLFM"))) > (call-interactively 'org-table-edit-formulas)) > (t (call-interactively 'ffap)))) > > -------patch--------end--------- > > This is my very first public org-mode patch and my very first hack in > vital org-mode elisp code. Thus, don't laugh or blame to much.... :) > > Best regards > Torsten > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode