From: Carsten Dominik <dominik@science.uva.nl>
To: Ben Alexander <ben@alexanderonline.org>
Cc: emacs-orgmode Org-Mode <emacs-orgmode@gnu.org>
Subject: Re: Problem with org-toggle-timestamp-type
Date: Sat, 1 Nov 2008 14:48:40 +0100 [thread overview]
Message-ID: <88813C58-031D-41AE-9590-2B50E4824C79@uva.nl> (raw)
In-Reply-To: <0A7CF9F9-391A-4424-AB1A-D124293AD9A8@alexanderonline.org>
Hi Ben,
On Oct 29, 2008, at 9:46 PM, Ben Alexander wrote:
> Hi!
>
> I'm cannot figure out how to use version control in general, and git
> in particular. However, I think there is a mistake with org-toggle-
> timestamp-type.
>
> Currently, the message always returns "Timestamp is now active"
> regardless of wether it is or not. I think this is because the
> message is not inside the save-excursion block, so we can't be sure
> whether point was outside the timestamp (just in front) or inside
> (at the very end). Inside save-excursion, I think it is always
> moved to the end, does the edit, and is moved outside.
>
> Also, I think the sense of the test is backwards. And for some
> reason (if (equal (char-before) ?]) "in" "") didn't work (went to
> elisp debugger). I can't read lisp, it's beyond me.
>
> So here's the change I made (to org-version 6.10c)
>
>
> (defun org-toggle-timestamp-type ()
> "Toggle the type (<active> or [inactive]) of a time stamp."
> (interactive)
> (when (org-at-timestamp-p t)
> (save-excursion
> (goto-char (match-beginning 0))
> (insert (if (equal (char-after) ?<) "[" "<")) (delete-char 1)
> (goto-char (1- (match-end 0)))
> (insert (if (equal (char-after) ?>) "]" ">")) (delete-char 1)
> (message "Timestamp is now %sactive"
> (if (equal (char-before) ?>) "" "in")))))
I have applied a similar fix, thanks.
>
>
> There's something else, and this might very well because my git repo
> is not what emacs is actually running, and my modified Makefile
> install target might be foobar.
>
> If I have a timestamp that looks like <2009-01-29 Thu>--<2009-01-29
> Thu> and the cursor is in front of the first > symbol and then I hit
> the S-<up> twice, my timestamp no longer is a range. It now looks
> like [2009-01-30 Fri]
>
> I tried to look at the org-ts[r]?-regexp-* variables, but my eyes
> crossed. Plus, I'm very afraid that any change I'd make would add
> parentheses, and thereby screwup every (match-begin 8) in the code.
Yes, there is a problem with this regexp, and I not not know myself
how to fix it. Negated character classes do not seem to work as
advertised if there is a bracket inside.
Thanks!
- Carsten
prev parent reply other threads:[~2008-11-01 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0A7CF9F9-391A-4424-AB1A-D124293AD9A8@alexanderonline.org>
2008-10-30 15:21 ` Problem with org-toggle-timestamp-type Ben Alexander
2008-10-30 15:46 ` Richard Riley
2008-11-01 13:48 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88813C58-031D-41AE-9590-2B50E4824C79@uva.nl \
--to=dominik@science.uva.nl \
--cc=ben@alexanderonline.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).