emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nick Dokos <nicholas.dokos@hp.com>
To: Samuel Wales <samologist@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Annoying behavior of RET after a timestamp
Date: Tue, 29 May 2012 15:15:28 -0400	[thread overview]
Message-ID: <8836.1338318928@alphaville> (raw)
In-Reply-To: Message from Samuel Wales <samologist@gmail.com> of "Tue, 29 May 2012 11:57:18 PDT." <CAJcAo8taDM28r78xB3P0cmMLMaoSxxeLLVe_PL7jkj1eWsaA3g@mail.gmail.com>

Samuel Wales <samologist@gmail.com> wrote:

> WFM now too in a quick test.  However, I wanted to point out that I'm
> not sure it's a new bug only, in case it's relevant to bisecting.
> 

Well, I don't know about the link bug you remember, but the timestamp
"bug" (if it is a bug) was introduced by the following commit:

,----
| commit e01ce26c0bed630a1656fde8552e268d477326f8
| Author: Bastien Guerry <bzg@altern.org>
| Date:   Mon Aug 15 10:06:02 2011 +0200
| 
|     org.el: set `org-ts-what' correctly in `org-at-timestamp-p'.
|     
|     (org-at-timestamp-p): set `org-ts-what' in a way that point will be
|     considered to be "on the bracket" whether it is really on it or right
|     after it.
|     
|     Thanks to Matt Lundin for reporting this and to Nicolas Goaziou for
|     discussion about this.
| 
| diff --git a/lisp/org.el b/lisp/org.el
| index f40f46c..4de51b9 100644
| --- a/lisp/org.el
| +++ b/lisp/org.el
| @@ -15586,7 +15586,10 @@ (defun org-at-timestamp-p (&optional inactive-ok)
|  	 (setq org-ts-what
|  	      (cond
|  	       ((= pos (match-beginning 0))         'bracket)
| -	       ((= pos (1- (match-end 0)))          'bracket)
| +	       ;; Point is considered to be "on the bracket" whether
| +	       ;; it's really on it or right after it.
| +	       ((or (= pos (1- (match-end 0)))
| +                    (= pos (match-end 0)))          'bracket)
|  	       ((org-pos-in-match-range pos 2)      'year)
|  	       ((org-pos-in-match-range pos 3)      'month)
|  	       ((org-pos-in-match-range pos 7)      'hour)
`----

I haven't gone to gmane looking for the discussion, but if one of the
principals involved remembers the reason, maybe they can enlighten us.

Thanks,
Nick

  parent reply	other threads:[~2012-05-29 19:15 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-29 17:24 Annoying behavior of RET after a timestamp Nick Dokos
2012-05-29 17:46 ` Nick Dokos
2012-05-29 17:54   ` Samuel Wales
2012-05-29 18:43     ` Nick Dokos
2012-05-29 18:57       ` Samuel Wales
2012-05-29 19:04         ` suvayu ali
2012-05-29 19:15         ` Nick Dokos [this message]
2012-05-29 19:21           ` Nick Dokos
2012-05-29 19:26             ` Nick Dokos
2012-05-29 20:05               ` Samuel Wales
2012-05-31 12:43               ` Matt Lundin
2012-06-01 13:57                 ` Bastien
2012-06-01 13:55 ` Bastien
2012-06-01 15:41   ` Nick Dokos
  -- strict thread matches above, loose matches on Subject: below --
2010-11-11 22:05 HTML export and blogging to blogger.com Samuel Wales
2010-11-11 22:50 ` Nick Dokos
2010-11-11 23:06   ` Samuel Wales
2010-11-12  3:45     ` Nick Dokos
2010-11-11 23:07 ` John Hendy
2010-11-11 23:18   ` Samuel Wales
2010-11-11 23:40     ` John Hendy
2010-11-12  2:25       ` Samuel Wales
2010-11-12 10:47         ` Eric S Fraga
2010-11-12 19:32           ` Samuel Wales
2010-11-14  1:25 ` Samuel Wales
2010-11-14  2:26   ` John Hendy
2010-11-14  2:54     ` Samuel Wales
2010-11-16  3:01   ` Samuel Wales
2010-11-16  9:50     ` Giovanni Ridolfi
2010-11-16 18:26       ` Samuel Wales
2010-11-16 23:17         ` Samuel Wales
2010-11-16 23:32           ` John Hendy
2010-11-17  0:13             ` Samuel Wales
2010-11-17  0:17               ` Samuel Wales
2010-11-17  4:34                 ` John Hendy
2010-11-17  4:45                   ` John Hendy
2010-11-17  9:09                     ` Eric S Fraga
2010-11-17 16:36                       ` John Hendy
2010-11-17 16:46                         ` Eric S Fraga
2010-11-24  1:59                       ` Samuel Wales
2010-11-24  9:09                         ` Eric S Fraga
2010-11-24  2:03                   ` Samuel Wales
2010-11-17 11:47         ` Christian Moe
2010-11-17 12:28           ` Add a hook with #+BIND? Christian Moe
2010-11-18  5:44           ` Re: HTML export and blogging to blogger.com John Hendy
2010-11-17  3:46   ` Nick Dokos
2010-11-17  4:18     ` John Hendy
2010-11-17  5:17       ` Nick Dokos
2010-11-17  5:52     ` Samuel Wales
2010-11-17  6:09       ` Nick Dokos
2010-11-24  2:00         ` Samuel Wales
2010-11-17 10:17       ` Tim Burt
2010-11-24  1:58         ` Samuel Wales
2009-06-11 11:58 tea-time? henry atting
2009-06-11 12:34 ` tea-time? Sebastian Rose
2009-07-17  3:56   ` tea-time? Samuel Wales
2009-07-17  7:24     ` tea-time? Bastien
2009-07-25 19:49       ` tea-time? Samuel Wales
2009-07-25 22:20         ` tea-time? Bastien
2009-07-26  0:14           ` tea-time? Samuel Wales
2009-07-26 19:04             ` tea-time? Bastien
2009-07-29 17:30               ` tea-time? Samuel Wales
2009-07-29 17:31                 ` tea-time? Samuel Wales
2009-07-29 17:41                 ` tea-time? Bastien
2009-07-29 17:54                   ` tea-time? Samuel Wales
2009-07-29 18:41                     ` tea-time? Bastien
2009-07-29 19:06                 ` tea-time? Bastien
2009-07-29 21:45                   ` tea-time? Samuel Wales
2009-07-29 22:29                     ` tea-time? Nick Dokos
2009-07-30  5:18                       ` tea-time? Bastien
2009-07-30 10:56                       ` tea-time? Eric S Fraga
2009-07-30 12:34                         ` tea-time? Richard Riley
2009-07-30  5:48                     ` tea-time? Bastien
     [not found]                     ` <samologist@gmail.com>
2012-08-28  1:11                       ` How to make kill-sexp work as in the rest of Emacs? Samuel Wales
2012-08-28  3:43                         ` Nick Dokos
2012-08-28  4:08                           ` Samuel Wales
2012-08-28  5:30                             ` Nick Dokos
2012-08-28  5:33                               ` Samuel Wales
2012-08-30  5:04                               ` Bastien
2009-07-17 12:46     ` tea-time? Bernt Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8836.1338318928@alphaville \
    --to=nicholas.dokos@hp.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=samologist@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).