From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Rose Subject: Re: [Patch] file protocol in HTML links Date: Wed, 26 May 2010 11:51:42 +0200 Message-ID: <87zkznkn2p.fsf@gmx.de> References: <874ohvm2bk.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=45038 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHDHC-0004mz-FW for emacs-orgmode@gnu.org; Wed, 26 May 2010 05:51:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHDHA-00022G-Uk for emacs-orgmode@gnu.org; Wed, 26 May 2010 05:51:50 -0400 Received: from mail.gmx.net ([213.165.64.20]:38192) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1OHDHA-00021w-IK for emacs-orgmode@gnu.org; Wed, 26 May 2010 05:51:48 -0400 In-Reply-To: <874ohvm2bk.fsf@gmx.de> (Sebastian Rose's message of "Wed, 26 May 2010 11:37:03 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Emacs-orgmode mailing list Sebastian Rose writes: > The appended patch removes the protocol part from link URIs, if the > protocol is file. Neccessary, to show images again and make links work. > > > diff --git a/lisp/org-html.el b/lisp/org-html.el > index d5f4775..8f7d0f3 100644 > --- a/lisp/org-html.el > +++ b/lisp/org-html.el > @@ -640,7 +640,7 @@ MAY-INLINE-P allows inlining it as an image." > (setq thefile > (let > ((str (org-export-html-format-href thefile))) > - (if type > + (if (and type (not (string= "file" type))) > (concat type ":" str) > str))) Hi, I just pulled and saw it was fixed already - but in a wrong way, I believe. How about an absolute link URL with a different protocol like gopher? I think adding the protocol should be done, if the protocol is different from that used to deliver the file which contains the link. There's no need to add the protocol to an absolute path. Sebastian