From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Separate clocksum format for durations >= 1 day Date: Wed, 14 Nov 2012 17:09:38 +0100 Message-ID: <87zk2kyxml.fsf@gmail.com> References: <877gpo1b16.fsf@gmail.com> <20121114153710.GA15676@c3po> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:41449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYfbB-000569-9E for emacs-orgmode@gnu.org; Wed, 14 Nov 2012 11:14:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYfb8-00054R-7D for emacs-orgmode@gnu.org; Wed, 14 Nov 2012 11:13:57 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:44105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYfb8-00054N-0n for emacs-orgmode@gnu.org; Wed, 14 Nov 2012 11:13:54 -0500 Received: by mail-wi0-f171.google.com with SMTP id c10so2408178wiw.12 for ; Wed, 14 Nov 2012 08:13:53 -0800 (PST) In-Reply-To: <20121114153710.GA15676@c3po> (Toby Cubitt's message of "Wed, 14 Nov 2012 16:37:10 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Toby Cubitt writes: > I can easily allow org-time-clocksum-fractional-format to be a list of > formats. But "1d 3.4h" doesn't seem very useful to me. Probably it should > work a bit differently: format the time as a fractional quantity, using > the largest time unit which will give a non-zero integer part. > > Does that sound reasonable? That's the idea, yes. Though, it will be the largest time unit _with a format string_ which will give a non-zero integer part. > OK, but in this case I think the single-format-string option is still > useful. It gives users a simpler way of customizing the format if they > don't want to do anything fancy. If they don't want to do anything fancy, they use the default value, whatever it may be. ;) I don't mind keeping the single format string option anyway. > I'll post an updated patch when I get time to make the changes. Since it's for 8.0, there's no hurry. I'll wait for you to merge the two patches and make subsequent changes. Thank you. Regards, -- Nicolas Goaziou