From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [PATCH 09/10] Remove org-babel-check-confirm-evaluate macro Date: Tue, 02 Apr 2013 21:53:45 +0200 Message-ID: <87zjxgso8m.fsf@Rainer.invalid> References: <1364794944-13826-1-git-send-email-aaronecay@gmail.com> <1364794944-13826-10-git-send-email-aaronecay@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:37271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UN7HQ-0004yo-8w for emacs-orgmode@gnu.org; Tue, 02 Apr 2013 15:54:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UN7HP-0003SV-0x for emacs-orgmode@gnu.org; Tue, 02 Apr 2013 15:54:04 -0400 Received: from plane.gmane.org ([80.91.229.3]:58927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UN7HO-0003SM-QA for emacs-orgmode@gnu.org; Tue, 02 Apr 2013 15:54:02 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UN7Hk-0007Qo-UG for emacs-orgmode@gnu.org; Tue, 02 Apr 2013 21:54:24 +0200 Received: from pd9eb32ad.dip.t-dialin.net ([217.235.50.173]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 02 Apr 2013 21:54:24 +0200 Received: from Stromeko by pd9eb32ad.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 02 Apr 2013 21:54:24 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Aaron Ecay writes: > * lisp/ob-core.el (org-babel-check-confirm-evaluate): remove > (org-babel-check-evaluate), > (org-babel-confirm-evaluate): move logic here > > This macro is used in only two places, and has two almost-independent > complex logics coded into it. So, suppress the macro and move the logic > into the respective functions. I have recently introduced that macro because no amount of documentation can guarantee that the two functions using these values compute them the same way when somebody makes further changes down the road. That is, however, mandatory for these functions to work properly and safely. I haven't checked if the logic hasn't changed with that patch, but I don't think it's any easier to understand than before. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Terratec KOMPLEXER: http://Synth.Stromeko.net/Downloads.html#KomplexerWaves