From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lawrence Mitchell Subject: Re: [PATCH] ox-html: Ensure space between tag and attribute when closing tags Date: Tue, 07 May 2013 18:58:22 +0100 Message-ID: <87zjw6wu2p.fsf@gmx.li> References: <874neeybia.fsf@gmx.li> <8738tya7sl.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:42939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZm9t-0004Z2-Jj for emacs-orgmode@gnu.org; Tue, 07 May 2013 13:58:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZm9s-0004iM-DM for emacs-orgmode@gnu.org; Tue, 07 May 2013 13:58:37 -0400 Received: from plane.gmane.org ([80.91.229.3]:34581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZm9s-0004iA-6K for emacs-orgmode@gnu.org; Tue, 07 May 2013 13:58:36 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UZm9p-0006xC-RJ for emacs-orgmode@gnu.org; Tue, 07 May 2013 19:58:33 +0200 Received: from e4300lm.epcc.ed.ac.uk ([129.215.63.156]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 07 May 2013 19:58:33 +0200 Received: from wence by e4300lm.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 07 May 2013 19:58:33 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Bastien wrote: > Hi Lawrence, > Lawrence Mitchell writes: >> * lisp/ox-html.el (org-html-close-tag): Add space before attr. > thanks for the patch -- can you make it against the maint branch > so that we include this in the next minor release? It does not > apply against master. It won't apply against maint because the ox-html changes that introduced the problem (9bc55c, Export to various flavors of (X)HTML) are on master, not maint. My patch definitely applies against master: $ git checkout master $ git describe release_8.0.2-91-g29ab1bb $ git am ... $ git diff origin/master diff --git c/lisp/ox-html.el w/lisp/ox-html.el index 05b99bf..0379567 100644 --- c/lisp/ox-html.el +++ w/lisp/ox-html.el @@ -1301,7 +1301,7 @@ CSS classes, then this prefix can be very useful." (member dt '("html5" "xhtml5" "")))) (defun org-html-close-tag (tag attr info) - (concat "<" tag (or attr "") + (concat "<" tag " " attr (if (org-html-xhtml-p info) " />" ">"))) (defun org-html--make-attribute-string (attributes) -- Lawrence Mitchell