emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Yoshinari Nomura <nom@quickhack.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Add figure/table numbers to HTML captions
Date: Sat, 29 Jun 2013 10:02:07 +0200	[thread overview]
Message-ID: <87zju9pcow.fsf@gmail.com> (raw)
In-Reply-To: <20130629.160115.263707471452837649.nom@quickhack.net> (Yoshinari Nomura's message of "Sat, 29 Jun 2013 16:01:15 +0900 (JST)")

Hello,

Yoshinari Nomura <nom@quickhack.net> writes:

> I've split my work into these three commits:
>   0001-ox-html-add-figure-and-table-numbers-to-HTML-caption.patch
>   0002-ox-add-dictionary-entry-for-numbered-figures.patch
>   0003-ox-add-Japanese-translations-for-figures-and-tables.patch
>   (enclosed in the attachments)

Thanks for your work. Some minor comments below.

> commit a82e712c3d60d8b58e2cffe13d5cbcdfa25ede24
> Author: Yoshinari Nomura <nom@quickhack.net>
> Date:   Sat Jun 29 15:06:49 2013 +0900
>
>     ox: add Japanese translations for figures and tables
>     
>     * lisp/ox.el: (org-export-dictionary): Add Japanese translations for
>     figures and tables

You need to add TINYCHANGE at the end of your commit messages, since,
AFAIK, you haven't signed FSF papers yet.

> -	   (let ((path (org-export-solidify-link-text path)) number)
> +	   (let* ((path (org-export-solidify-link-text path)) number
> +		  (caption-predicate
> +		   (if (org-html--has-caption-p destination)
> +		       'org-html--has-caption-p))

You can remove this. Just use `org-html--has-caption-p' and replaces
references to `caption-predicate' below with it.

Otherwise, the patch looks good. Could you send the files as an
attachment? It will be easier for me to apply them.


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2013-06-29  8:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 10:52 Add figure/table numbers to HTML captions Yoshinari Nomura
2013-06-27 11:34 ` Rasmus
2013-06-27 23:37   ` Yoshinari Nomura
2013-06-27 14:46 ` Nicolas Goaziou
2013-06-28  1:15   ` Yoshinari Nomura
2013-06-28  9:23     ` Nicolas Goaziou
2013-06-28 11:51       ` Yoshinari Nomura
2013-06-29  7:01       ` Yoshinari Nomura
2013-06-29  8:02         ` Nicolas Goaziou [this message]
2013-06-29 10:00           ` Yoshinari Nomura
2013-06-29 12:09             ` Nicolas Goaziou
2013-06-29 13:48               ` Yoshinari Nomura
     [not found]                 ` <rt-3.4.5-3864-1375881898-1936.839264-5-0@rt.gnu.org>
2013-08-08  0:43                   ` Yoshinari Nomura
2013-08-08 12:22                     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zju9pcow.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=nom@quickhack.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).