From: Bastien <bzg@gnu.org>
To: Florian Beck <fb@miszellen.de>
Cc: Nick Dokos <ndokos@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: org-map-entries moves point
Date: Thu, 06 Feb 2014 00:30:03 +0100 [thread overview]
Message-ID: <87zjm59lz8.fsf@bzg.ath.cx> (raw)
In-Reply-To: <52F2B6F1.6040102@miszellen.de> (Florian Beck's message of "Wed, 05 Feb 2014 23:10:57 +0100")
Hi Florian,
Florian Beck <fb@miszellen.de> writes:
> Missed that. But this reverts commit
> 3ec38f5c064c3270f54876ba33c5ca1097b46853 [1] (in org-map-entries)
>
> I was talking about
> fe3379bda6ca23474639b114592958bf14431c88 [2] (which did the same to
> org-agenda-prepare-buffer)
>
> In fact, the revert *caused* my bug. Again, the recipe:
>
> The bug doesn't really move the point, rather it recenters the current
> line. To see it, move into the middle of a document, unfold a second
> level headline and in the middle of the window execute
>
> (org-map-entries (lambda ()
> ;; do something or even nothing
> ) nil 'tree)
>
> This works correctly if either commit [1] is restored or [2] is
> reverted.
I partially revert [2] (only replacing `save-window-excursion' by
`save-excursion') and didn't touch [1] -- if we can produce a bug
from there, let's fix it the right way this time.
Thanks in advance for digging further,
--
Bastien
prev parent reply other threads:[~2014-02-05 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 19:49 org-map-entries moves point Florian Beck
2014-02-05 20:59 ` Nick Dokos
2014-02-05 22:10 ` Florian Beck
2014-02-05 23:00 ` Nick Dokos
2014-02-05 23:30 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjm59lz8.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=fb@miszellen.de \
--cc=ndokos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).