From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Fix: Capture abort: (error: The mark is not set now, so there is no region) Date: Fri, 23 May 2014 14:03:12 +0200 Message-ID: <87zji88vye.fsf@bzg.ath.cx> References: <877g681jma.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnpXa-00066x-IE for emacs-orgmode@gnu.org; Fri, 23 May 2014 09:29:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnpXV-0002c9-8E for emacs-orgmode@gnu.org; Fri, 23 May 2014 09:29:42 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:57073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnpXV-0002bw-1H for emacs-orgmode@gnu.org; Fri, 23 May 2014 09:29:37 -0400 Received: by mail-wi0-f176.google.com with SMTP id n15so842634wiw.3 for ; Fri, 23 May 2014 06:29:36 -0700 (PDT) In-Reply-To: (Alex Kosorukoff's message of "Thu, 8 May 2014 20:55:50 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Alex Kosorukoff Cc: emacs-orgmode@gnu.org Hi Alex, Alex Kosorukoff writes: > After I replaced my patch and merged Bastien's fix, I started seeing > the error though less frequently than before. It didn't occur in the > template I posted, but I started seeing it again in another template. > > ("w" "org-protocol tag" entry (file "~/org/bookmarks.org") >                "* %:description %(org-set-tags)\n  %i\n\n  %:link\n%? > " >                :prepend t :empty-lines-after 1 :clock-in t > :clock-resume t) If I may ask, why using %(org-set-tags) instead of %^g or %^G? > I switched back to my initial patch that was checking if the mark was > set before trying to access the region. This worked: the errors > disappeared. I think the right fix is to exclude `mark-active' from the local variable that are imported through `org-capture-steal-local-variables'. I installed such a fix in maint, please update Org and let me know if this works for you. Thanks, -- Bastien