From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: [PATCH] org-attach.el: Get attachments from git annex Date: Thu, 04 Feb 2016 21:41:42 -0500 Message-ID: <87zivf98ux.fsf@kyleam.com> References: <568b532e.d111620a.b25a8.ffffbb7c@mx.google.com> <87poxg8s22.fsf@kyleam.com> <568c6aaa.c345620a.7f4da.6359@mx.google.com> <56a5b193.ca77420a.1551e.667c@mx.google.com> <87lh7dz79f.fsf@gmx.us> <56a70513.6861420a.33633.5843@mx.google.com> <87egd4u6tq.fsf@kyleam.com> <56a7a139.885d620a.6b777.576d@mx.google.com> <87io2gb5xh.fsf@kyleam.com> <87oac8hu9p.fsf@gmx.us> <56a87251.0e2a620a.4811f.fffff1c6@mx.google.com> <87lh79t04p.fsf@kyleam.com> <56b2c213.08e5420a.3d619.ffffd033@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRWLH-0003M3-Vl for emacs-orgmode@gnu.org; Thu, 04 Feb 2016 21:41:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRWLE-0001fO-RE for emacs-orgmode@gnu.org; Thu, 04 Feb 2016 21:41:51 -0500 Received: from pb-smtp0.int.icgroup.com ([208.72.237.35]:61553 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRWLE-0001fC-NI for emacs-orgmode@gnu.org; Thu, 04 Feb 2016 21:41:48 -0500 In-Reply-To: <56b2c213.08e5420a.3d619.ffffd033@mx.google.com> (Erik Hetzner's message of "Sun, 24 Jan 2016 20:34:20 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Erik Hetzner Cc: emacs-orgmode@gnu.org Erik Hetzner writes: > From: Erik Hetzner > > * org-attach.el (org-attach-use-annex): New function to check if git > annex should be used. > (org-attach-annex-get-maybe): New function to get a file from git > annex if necessary. > (org-attach-annex-auto-get): New defcustom to determine behavior > of org-attach-annex-get-maybe. > (org-attach-open): Automatically get attached files from git annex when > opening if necessary. > * testing/lisp/test-org-annex.el: New file for testing org-attach. Only > contains code for testing org-attach with git annex at the moment. > * mk/targets.mk: Fix cleantest target so it can delete git annex repos. > --- > lisp/org-attach.el | 69 ++++++++++++++++++++++------- > mk/targets.mk | 2 + > testing/lisp/test-org-attach.el | 97 +++++++++++++++++++++++++++++++++++++++++ This looks good to me. I'll leave applying the patch to Rasmus in case he has any comments on this version. Thank you. -- Kyle