emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] make tags fast selection popup narrower
@ 2018-04-15  9:49 stardiviner
  2018-04-15 15:26 ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: stardiviner @ 2018-04-15  9:49 UTC (permalink / raw)
  To: org-mode


[-- Attachment #1.1: Type: text/plain, Size: 20 bytes --]

Here is the patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-org.el-make-fast-tags-selection-popup-narrower-to-lo.patch --]
[-- Type: text/x-patch, Size: 1070 bytes --]

From 7fc28443484f7b8c701d7c076f1c9c4e389651e7 Mon Sep 17 00:00:00 2001
From: stardiviner <numbchild@gmail.com>
Date: Sun, 15 Apr 2018 17:41:44 +0800
Subject: [PATCH] * org.el: make fast tags selection popup narrower to look
 better.

* lisp/org.el (org-fast-tag-selection): original spaces behind each tag
  is calculated based on window width. It is big. Diffcult to find tags.
---
 lisp/org.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 4080f3884..e08129498 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14647,8 +14647,7 @@ Returns the new tags string, or nil to not change the current settings."
 	  (when (equal (caar tbl) :grouptags)
 	    (org-add-props tg nil 'face 'org-tag-group))
 	  (when (and (zerop cnt) (not ingroup) (not intaggroup)) (insert " "))
-	  (insert "[" c "] " tg (make-string
-				 (- fwidth 4 (length tg)) ?\ ))
+	  (insert "[" c "] " tg (make-string 2 ?\ ))
 	  (push (cons tg c) ntable)
 	  (when (= (cl-incf cnt) ncol)
 	    (insert "\n")
-- 
2.17.0


[-- Attachment #1.3: Type: text/plain, Size: 47 bytes --]


And I toke two screenshots.
Before my patch:


[-- Attachment #1.4: before.png --]
[-- Type: image/png, Size: 73272 bytes --]

[-- Attachment #1.5: Type: text/plain, Size: 18 bytes --]


After my patch:


[-- Attachment #1.6: after.png --]
[-- Type: image/png, Size: 69787 bytes --]

[-- Attachment #1.7: Type: text/plain, Size: 204 bytes --]



-- 
[ stardiviner ] don't need to convince with trends.
       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] make tags fast selection popup narrower
  2018-04-15  9:49 [PATCH] make tags fast selection popup narrower stardiviner
@ 2018-04-15 15:26 ` Nicolas Goaziou
  2018-04-15 15:56   ` stardiviner
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2018-04-15 15:26 UTC (permalink / raw)
  To: stardiviner; +Cc: org-mode

Hello,

stardiviner <numbchild@gmail.com> writes:

> Here is the patch:
>
> From 7fc28443484f7b8c701d7c076f1c9c4e389651e7 Mon Sep 17 00:00:00 2001
> From: stardiviner <numbchild@gmail.com>
> Date: Sun, 15 Apr 2018 17:41:44 +0800
> Subject: [PATCH] * org.el: make fast tags selection popup narrower to look
>  better.

Beauty lies in the eye of the beholder, yet, I don't find it to be an
improvement. It breaks the column alignment in most cases. Until we find
a more sensible display, we should preserve that vertical alignment.

Your problem stems from the special characters your are using, e.g.,
"\200". We may need a pixel based alignment to fix that.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] make tags fast selection popup narrower
  2018-04-15 15:26 ` Nicolas Goaziou
@ 2018-04-15 15:56   ` stardiviner
  0 siblings, 0 replies; 3+ messages in thread
From: stardiviner @ 2018-04-15 15:56 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: org-mode

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> Here is the patch:
>>
>> From 7fc28443484f7b8c701d7c076f1c9c4e389651e7 Mon Sep 17 00:00:00 2001
>> From: stardiviner <numbchild@gmail.com>
>> Date: Sun, 15 Apr 2018 17:41:44 +0800
>> Subject: [PATCH] * org.el: make fast tags selection popup narrower to look
>>  better.
>
> Beauty lies in the eye of the beholder, yet, I don't find it to be an
> improvement. It breaks the column alignment in most cases. Until we find
> a more sensible display, we should preserve that vertical alignment.
>
> Your problem stems from the special characters your are using, e.g.,
> "\200". We may need a pixel based alignment to fix that.
>
> Regards,

You're right. I will check it out.

- -- 
[ stardiviner ] don't need to convince with trends.
       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAlrTdiUACgkQG13xyVro
msMtgQgAvUt33xP3QWAWdmDjl/nzgNd6ENH7lF9dL9HsIbebh5FpYc89TcEGznFq
TxljK1G/CJhLzZs+jc93JdRE8B2lrphEUGd3LyxsrFaRW7tB0Xwc+0QAgxrXmEWv
+5nAj+xo4hEcuLFDneco3qn9ouq+hOYBsC03bmKBuDvriO25uHPfzop7yPGcEwDc
CkzB8AeRscSGByfaccl7RMQoYcrOZhljQG9ls7ofvTtcCeOghV/W4YZv3RQ9FlPB
XhGwOHfrZ04CgEGjnOhTAMpDwq0oMNFsBIPFU0SlfMy+OlB/QudOy8GUtT1ms7TM
69KGeOVcEsiYkjuxD3O5JdKypVZwQw==
=60nf
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-15 15:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-15  9:49 [PATCH] make tags fast selection popup narrower stardiviner
2018-04-15 15:26 ` Nicolas Goaziou
2018-04-15 15:56   ` stardiviner

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).