From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Fix org-meta-return for checkbox lists Date: Thu, 14 Jun 2018 20:41:15 +0200 Message-ID: <87zhzx8b3o.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTXBS-0005W6-Mu for emacs-orgmode@gnu.org; Thu, 14 Jun 2018 14:41:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTXBO-0008AJ-Jf for emacs-orgmode@gnu.org; Thu, 14 Jun 2018 14:41:22 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:53117) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTXBO-00087w-DK for emacs-orgmode@gnu.org; Thu, 14 Jun 2018 14:41:18 -0400 In-Reply-To: (Kaushal Modi's message of "Thu, 14 Jun 2018 11:30:37 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Kaushal Modi Cc: emacs-org list Hello, Kaushal Modi writes: > Currently if you do M-RET in a checkbox list item, the next item does not > become a checkbox automatically. This patch fixes that. > > I have been using this fix locally for few months. But never got to > submitting it as I need to yet write a test for it. > > Does that patch look good (apart from missing tests). Should I format it > w.r.t to next? or master? IMO, there is nothing to fix. Inserting a checkbox in every item is not mandatory. Furthermore, currently, M-RET inserts a regular item and M-S-RET inserts it with a checkbox. With your patch, both M-RET and M-S-RET do the same thing, which is sub-optimal. My vote is to keep the current behaviour. Regards, -- Nicolas Goaziou