From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: attachment: link type export to HTML invalid attach dir Date: Fri, 14 Feb 2020 12:06:17 +0100 Message-ID: <87zhdlctsm.fsf@bzg.fr> References: <87eevyud9u.fsf@nicolasgoaziou.fr> <87pnfhrob4.fsf@nicolasgoaziou.fr> <871rrvrw0b.fsf@nicolasgoaziou.fr> <87muairkam.fsf@nicolasgoaziou.fr> <87y2th0yc7.fsf@nicolasgoaziou.fr> <878sle1ng9.fsf@nicolasgoaziou.fr> <875zgausnb.fsf@nicolasgoaziou.fr> <87o8u2tbhg.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:45097) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2Yo1-0005nh-FN for emacs-orgmode@gnu.org; Fri, 14 Feb 2020 06:06:46 -0500 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Gustav =?utf-8?Q?Wikstr=C3=B6m?= Cc: "emacs-orgmode@gnu.org" , Nicolas Goaziou Okay, I've done my home work :) TL;DR: (1) The change is fresh, let's take the time to work together at making it right before 9.4*; (2) the current state with the line 3216 in org-element.el is not okay; (3) let's try implementing what Nicolas suggests wrt to attachment=>file link resolution. * Sorry that I rushed you into having this discussion by announcing the release with such a short notice, I should have seen this was not resolve. Now into more details. - The new feature for attachments is nice and useful. And I'm quite happy Gustav is now more acquainted with org-element.el -- we need more people with a good knowledge of that core file (thanks!) - My definition of Org core link types = the minimal set of types to which other types can be translated to. Given this definition, an attachment is not a core link type as it can resolve to file type. - org-element.el should only know about core link types. - Link type resolution should happen at exporting time: I think the design consistency is worth the potential parsing time cost. - One advantage of this approach (on top of design consistency) is that exporters won't each depend on org-attach.el to deal with file attachments, as they do right now. Now, I'm not sure who wants to try implementing Nicolas suggestion to let ox.el expand attachments into file links: since you both know the issue better than I do, I suggest one of you can try? We are not pressed by time, so whoever has the energy to finish this. Thanks! -- Bastien