emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Vladimir Panteleev <thecybershadow@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-shiftright etc. do not respect org-support-shift-select [9.3.6 (9.3.6-elpa @ /home/vladimir/.emacs.d/elpa/org-9.3.6/)]
Date: Tue, 07 Apr 2020 05:19:08 +0000	[thread overview]
Message-ID: <87zhbnzxdf.fsf@kyleam.com> (raw)
In-Reply-To: <CAHhfkvw8O4cSxe5CJXQ8L+ce+9wOhuM==Xv9rB2NVhsCgYANdA@mail.gmail.com>

Vladimir Panteleev <thecybershadow@gmail.com> writes:

> I have org-support-shift-select set to 'always. As such, when editing
> tables, I expect that Shift + arrow keys to enable Emacs shift
> selection. Instead, it moves table cells around.
>
> This behavior did not exist in Org 9.1.9.

The change in behavior happened with 09f950723 (Added keybindings for
`org-table-move-cell-*' functions), which was a part of the v9.3
release.  Looking at that commit and scanning the associated thread [^],
I'm guessing the interaction with org-support-shift-select was simply
overlooked and those org-table-move-cell-* calls should be updated to
inspect org-support-shift-select, like (some of) the other neighboring
branches in the code.

I'll take a look at doing that tomorrow.

> The documentation of org-support-shift-select should also be updated
> to include tables in the list of contexts where shifted cursor keys
> execute Org commands.

True.

Thanks for the report.


[^]: https://yhetil.org/orgmode/CAKj7sHGdxaor6Lwe+pg481Z7DyHXXr6DDWrBWGa2VCyX+RKy+w@mail.gmail.com/T/#u


  reply	other threads:[~2020-04-07  5:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05  8:40 Vladimir Panteleev
2020-04-07  5:19 ` Kyle Meyer [this message]
2020-04-08  4:26   ` [PATCH] org-shift*: Honor org-support-shift-select for table cell movement Kyle Meyer
2020-04-10  2:32     ` Kyle Meyer
  -- strict thread matches above, loose matches on Subject: below --
2020-04-05  8:36 Bug: org-shiftright etc. do not respect org-support-shift-select [9.3.6 (9.3.6-elpa @ /home/vladimir/.emacs.d/elpa/org-9.3.6/)] vladimir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhbnzxdf.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=thecybershadow@gmail.com \
    --subject='Re: Bug: org-shiftright etc. do not respect org-support-shift-select [9.3.6 (9.3.6-elpa @ /home/vladimir/.emacs.d/elpa/org-9.3.6/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).