emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kevin Liu <kevin@nivekuil.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix org-narrow-to-subtree smaller than subtree
Date: Sat, 30 May 2020 18:05:42 +0200	[thread overview]
Message-ID: <87zh9pmmqx.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <877dwtpmum.fsf@nivekuil.com> (Kevin Liu's message of "Sat, 30 May 2020 06:35:13 -0700")

Hello,

Kevin Liu <kevin@nivekuil.com> writes:

> Right now a narrowed subtree is one char smaller than the actual
> subtree.  (org-mark-element) on a narrowed subtree will select a
> region 1 char out of bounds, for example.  There doesn't seem like a
> good reason for this to be the case.

There is a good reason for this. If you insert text at (point-max), you
break the following headline.

OTOH `org-mark-element' should pay attention to buffer boundaries.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2020-05-30 16:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-30 13:29 [PATCH] Fix org-narrow-to-subtree smaller than subtree Kevin Liu
2020-05-30 13:35 ` Kevin Liu
2020-05-30 16:05   ` Nicolas Goaziou [this message]
2020-05-31  1:54     ` Kevin Liu
2020-05-31 12:23       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh9pmmqx.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kevin@nivekuil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).