From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MN8FGMvwO1+eagAA0tVLHw (envelope-from ) for ; Tue, 18 Aug 2020 15:16:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yOzmE8vwO191VQAA1q6Kng (envelope-from ) for ; Tue, 18 Aug 2020 15:16:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D8A729403A0 for ; Tue, 18 Aug 2020 15:16:26 +0000 (UTC) Received: from localhost ([::1]:58362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k83Ld-0006R8-Mq for larch@yhetil.org; Tue, 18 Aug 2020 11:16:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k82Ux-0006OH-S6 for emacs-orgmode@gnu.org; Tue, 18 Aug 2020 10:21:59 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:43991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k82Uv-0000Pa-5C for emacs-orgmode@gnu.org; Tue, 18 Aug 2020 10:21:59 -0400 Received: by mail-pf1-x441.google.com with SMTP id y206so10020778pfb.10 for ; Tue, 18 Aug 2020 07:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=PeZtIbme/jUGvqGu6d4qeSr90PAGsOoa4/UNqWT/Z24=; b=L8JVVwMkKwuORtIP8Y/EENo7PNsCYjbzhcI2v+OY9P8ELo+LMF8X/glJUEfjHNCRh1 77K6HL1caeRI7xu/Mk8Y11ownwRp7RNGSxqMDJquP+c5Cr0eBzefphDRwp/eCdCIBpm4 taDcS4O6tPjXkx81Fmx6+sR/PzwnCOdoE+PP25qpl/T7Y/Ns81apPq1PhQt/a8G19DlB b28OCaZY2XqtoZjyLCP6ZrALQ8jZmxStbWepwb+pqdsmk6b1g9WxrcG6E2r5cPk2AiLz BEl1pNkuy4m1vsJiZzASrQNQscwYU/cvG7IuQkZDOyufpg5y4XdwFkjVDNWw0H4rZlLk gYKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=PeZtIbme/jUGvqGu6d4qeSr90PAGsOoa4/UNqWT/Z24=; b=S94fQglpLGwKA4oJByMQDBVYpz6kiDJORgMX9tKSrS0bCUd+DM+pOwLvf5/GHY1fvY +gdtok9+xLWsS1r5csEu8bmWfOIMv8o9SX+XBncBBAKRKsz/Ym2oFe1c5AjzgFXYNEC/ /6S6BhzWrkROVs2FQGTy7BlGt9f5Q08g8pFnP6FS2dBq+PqhYfgcaW2XsZCJ8zENOFEz +CP7fpR4vUSRaLBlVPbmsHO8dCYE2xfJxKDpAWU/YzVt5bg3QNyEkwrbOSxkggwpQW/r nT5Vr3ZCenu0cZ4CdCPV5mh0PcoYyy1/gyG05m8wqkPI05QrCmb58tg1qtPNPSq+Bj47 xBpA== X-Gm-Message-State: AOAM532eOBw2laQt83g0WTNjKP9Rw787To8D8kg1JY2HISsiWBZSZK2a O2ICGi/Sju+b1GHiRz8sYFc= X-Google-Smtp-Source: ABdhPJxX/AZ4vsxhL7GoTzta99TpFgCirdD2nOWKescrnVh7pUTe2dPCk8uu6gY4Ftoeq5P25BlHSg== X-Received: by 2002:aa7:9341:: with SMTP id 1mr15643267pfn.40.1597760514962; Tue, 18 Aug 2020 07:21:54 -0700 (PDT) Received: from localhost (199-83-220-90.PUBLIC.monkeybrains.net. [199.83.220.90]) by smtp.gmail.com with ESMTPSA id n22sm135215pjq.25.2020.08.18.07.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2020 07:21:54 -0700 (PDT) From: Jack Kamm To: Christian Vanderwall , emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-python.el: Fix issue with sessions on remote machines In-Reply-To: <87h7t16red.fsf@pc.i-did-not-set--mail-host-address--so-tickle-me> References: <87h7t16red.fsf@pc.i-did-not-set--mail-host-address--so-tickle-me> Date: Tue, 18 Aug 2020 07:21:53 -0700 Message-ID: <87zh6syqym.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::441; envelope-from=jackkamm@gmail.com; helo=mail-pf1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=L8JVVwMk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: J3FEsc/QP4KV Hi Christian, Thanks for reporting this and providing a fix! > The function `org-babel-python-evaluate-session' doesn't process temp > file names with `org-babel-process-file-name' before inserting them into > the Python code blocks. This causes a 'No such file' error when the > executing the code blocks on a remote directory. I tested this out and was able to reproduce the bug. > The attached patch fixes this issue, allowing compilation of Python > source blocks with a remote directory, such as :dir /ssh:user@server:/. I tested your patch and it solves the problem. > This is my first patch ever, so please let me know if there's ways I can > improve. The patch is pretty simple and I see no problems with it. Since it is so small, FSF copyright assignment shouldn't be necessary. Also, it looks like you followed all the guidelines on https://orgmode.org/worg/org-contribute.html. I'm fairly novice myself so will wait a couple days in case one of the more experienced folks notices any issues here. But I'll merge this to master by end of week if I don't hear anything.