From: Christopher Lemmer Webber <cwebber@dustycloud.org>
To: emacs-orgmode@gnu.org
Subject: Bug: ODT exporter permission issue on functional distros (eg, Guix) [9.1.9 (release_9.1.9-65-g5e4542 @ /home/cwebber/.guix-profile/share/emacs/26.3/lisp/org/)]
Date: Sun, 11 Oct 2020 13:15:14 -0400 [thread overview]
Message-ID: <87zh4s7kgt.fsf@dustycloud.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
Emacs : GNU Emacs 26.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20)
Package: Org mode version 9.1.9 (release_9.1.9-65-g5e4542 @ /home/cwebber/.guix-profile/share/emacs/26.3/lisp/org/)
Not sure if this will work on Windows because it uses posix'y
permissions.... but anyway I found that the ODT exporter did not work on
Guix because the styles.xml got copied over as read-only. This fixes it
for me.
I've already done copyright assignment for the "AM/PM support on the
agenda timegrid" patch I sent in 2010; I assume this has not expired
over the last decade. If you check the use-by date and my copyright
assignment has somehow gone moldy let me know and I'll be happy to
update it.
- Chris
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ox-odt-Fix-read-only-error-with-styles.xml.patch --]
[-- Type: text/x-patch, Size: 1541 bytes --]
From df53e6282e7113b2601490266315f5018d7f2d6b Mon Sep 17 00:00:00 2001
From: Christopher Lemmer Webber <cwebber@dustycloud.org>
Date: Sun, 11 Oct 2020 12:56:34 -0400
Subject: [PATCH] ox-odt: Fix read-only error with styles.xml.
On systems where the source file is read-only, it's possible that
the destination styles.xml could end up read-only as well, resulting
in an error when modified or deleted by us.
* lisp/ox-odt.el (org-odt-template): Explicitly set permissions of
styles.xml to read-write for the current user.
---
lisp/ox-odt.el | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el
index 104319a9d..c2693d883 100644
--- a/lisp/ox-odt.el
+++ b/lisp/ox-odt.el
@@ -1375,7 +1375,13 @@ original parsed data. INFO is a plist holding export options."
((string= styles-file-type "xml")
(copy-file styles-file (concat org-odt-zip-dir "styles.xml") t))
((member styles-file-type '("odt" "ott"))
- (org-odt--zip-extract styles-file "styles.xml" org-odt-zip-dir)))))
+ (org-odt--zip-extract styles-file "styles.xml" org-odt-zip-dir)))
+ ;; It's possible that when copying the file from a location that's
+ ;; read-only that we accidentally end up with a read-only styles.xml
+ ;; here also (eg on Guix systems)... this prevents that from
+ ;; blowing up
+ (set-file-modes (concat org-odt-zip-dir "styles.xml")
+ #o600)))
(t
(error "Invalid specification of styles.xml file: %S"
(plist-get info :odt-styles-file))))
--
2.28.0
next reply other threads:[~2020-10-12 5:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 17:15 Christopher Lemmer Webber [this message]
2020-10-13 4:18 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh4s7kgt.fsf@dustycloud.org \
--to=cwebber@dustycloud.org \
--cc=emacs-orgmode@gnu.org \
--subject='Re: Bug: ODT exporter permission issue on functional distros (eg, Guix) [9.1.9 (release_9.1.9-65-g5e4542 @ /home/cwebber/.guix-profile/share/emacs/26.3/lisp/org/)]' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).