From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cB8EDejQk2A+KwEAgWs5BA (envelope-from ) for ; Thu, 06 May 2021 13:20:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oJqeCOjQk2ASagAAB5/wlQ (envelope-from ) for ; Thu, 06 May 2021 11:20:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 956361B83B for ; Thu, 6 May 2021 13:20:07 +0200 (CEST) Received: from localhost ([::1]:40920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lec34-0005Ru-PV for larch@yhetil.org; Thu, 06 May 2021 07:20:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lec2U-0005Q0-9A for emacs-orgmode@gnu.org; Thu, 06 May 2021 07:19:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59270) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lec2T-0000RF-NG; Thu, 06 May 2021 07:19:29 -0400 Received: from [2a01:e34:ec2b:7150:d86a:4dae:528a:d6f6] (port=45870 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1lec2T-0001wZ-HO; Thu, 06 May 2021 07:19:29 -0400 Received: by guerry (Postfix, from userid 1000) id A67201A60EDD; Thu, 6 May 2021 13:19:27 +0200 (CEST) From: Bastien To: =?utf-8?Q?S=C3=A9bastien?= Miquel Subject: Re: [PATCH] tangling seems to have broken today In-Reply-To: (=?utf-8?Q?=22S=C3=A9bastien?= Miquel"'s message of "Wed, 5 May 2021 16:22:16 +0000") Organization: GNU References: <8735v1uwqv.fsf@disroot.org> <87h7jhl2l7.fsf@gmail.com> <87a6p98fb0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Thu, 06 May 2021 13:19:27 +0200 Message-ID: <87zgx8qfcw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric S Fraga , emacs-orgmode@gnu.org, Timothy Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620300007; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3UX/w15T2/zmHN4yYF8uPqy/fi5EnSgUSSXwM3ebOqk=; b=DreiugN+RUUD1Khp5SUvl4klKojfr+VwtHtSQBl2zVMP9vUXgRynrOhduOtupGYuPlEEey q5Ij31KzG5D9r9d0GPYir9npr7W+Bs9u2jxh6rV0HTTnMfU+mNRaAOAfwm4f6pXiEL3mRd qVJyuQGVpL8YOk++GjXKMowBEt2akBrsdaOcD3Qdh7dGMwu0Cih7v8Rnxr4CRdHRgj2ARJ fBFGDQHNL6dz+817SjMel3vaLVp65bHpKgXlUg5Ik0r1KRLVvsCIEUfi+6SvnsuOg+H7gL k0MI3sZR6pWAZtfQKPDou8ZjpCVOnm4qlCMppcKjlgKmNORtCUe7SJPVSps/0Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620300007; a=rsa-sha256; cv=none; b=AEfeO5pTjBWSlky8IN8fycS7NTq3XJfB12gtzXYhO8kIBp5wS7gdMMi6nQTaX+g1eCUc2i 6c/wKjsC94OU/yjkNNY1jTXgGKkkjv2FkXyZz1YipWOvLBVd8/YnH1O85BbFnzyMjsp6KB /s0AoodoxsfSRZohoGsm+F7ttpSAEpbWEZxuRM5cZAgy8u3DSBp4AiWXCzMbbcMEamY1dl euSTy/kFCEcnE/Gmb8hqb1QAwHVLMy6Ba7dtkcD0xm3ZM0FahNGZgZlet+CmQU9C1tdvLz ZQN+PglkZaRnLHxqaLVdsjG7G+aAjFF+za3OMB6Z7DrGPZIBn7s4L40+dgTIZA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.46 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 956361B83B X-Spam-Score: -1.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: uMYJZubW9EXZ Hi S=C3=A9bastien, S=C3=A9bastien Miquel writes: > The issue is that currently tangling a single block by calling > `org-babel-tangle` with a prefix argument fails. This is unrelated to > the earlier thread today, but was introduced by my original commit > a2cb9b853d. > > Unfortunately, fixing it requires some refactorisation to avoid code > duplication. To keep the patch as simple as possible, I have > introduced a new helper function, I hope this is okay. > > I have tested the attached patch with the uses cases shown so far, as > well as my own and the org test suite. I think this should be applied to the maint branch, right? In this case, the patch does not apply. Can you check and repropose a patch against maint? Or just let me know if I'm mistaken. Thanks, --=20 Bastien