From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uksTBEtqWGFNDwEAgWs5BA (envelope-from ) for ; Sat, 02 Oct 2021 16:18:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kEvGOkpqWGEHbAAA1q6Kng (envelope-from ) for ; Sat, 02 Oct 2021 14:18:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4670F2EA90 for ; Sat, 2 Oct 2021 16:18:50 +0200 (CEST) Received: from localhost ([::1]:59114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWfqj-0007ye-EO for larch@yhetil.org; Sat, 02 Oct 2021 10:18:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWfo7-0005ZV-Sm for emacs-orgmode@gnu.org; Sat, 02 Oct 2021 10:16:07 -0400 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:35800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWfo6-0003lK-2l; Sat, 02 Oct 2021 10:16:07 -0400 Received: by mail-qt1-x82b.google.com with SMTP id c20so11782572qtb.2; Sat, 02 Oct 2021 07:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=qURG6ZoYvyqevL/gbWVsWI1KLFdmMnRZ9QY2kTQJhlU=; b=Wapx3LIuOUF9t5KGhJQvenWi/cZ+WeIlCDtswiHcYl1HHdv4zWfDpsjT+dnGoixGna qKQMtrVVXUhfepIhNNT2s5V8f8blyq3PQk7L+g53HGwuvzpSHz0AkV1Kol80uVquPY3H 07OOzQxi/Dkb9nNo5s1JSsQJ5KPAHO3GtZVLNN+QP5Lp7RqxnlziFgUK/GNGKBaW9DaF IISkC6pDHbWZwB19sFdmdZUdtiUXPu0ZjluteadG14Jck4LwKRdUkyRHo3eSeceJFSZl QhIrzrCGQmEE9BfvxyniTBCcUL+f3PqH2gAb2ChPg+9ANMhwKH74dfwgZTxuva+6HBn0 2ADA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=qURG6ZoYvyqevL/gbWVsWI1KLFdmMnRZ9QY2kTQJhlU=; b=vtoL1J9yQ+N6YKz1pA11jCDE+NrrEvGqm+J/6b/pOGNgcyPWBW57Cc6gFqltqD+rEV HNmpODaj0QLCI8MxD8s18kNEiUtlloUEa3Vr/Xw2n24wos0wuWWmKTMMrbNrukkrcJ8t ujnXazQdVDOO5jJTWeJpXON4o01Zs54whF5EJThWanBz7MXIEMkgmYq/QVS0MkThkVDB rvBuFHygUqt/h7xfYBm/POD/NFga2uS1k8jk8Fwqs3v4d0SsB6rHZbIw9NtBrvJrUQtE ZdHewhU9IK22b+vGUb1yih3qniPi+zxjjRsbKiwxLL5WtvcPXRQ8c5fwaJygMq/ri/eP C3+w== X-Gm-Message-State: AOAM532f/nI8M+18+nk3P3Ov22MTwVvF1ULgx+unDAAiJBcOaLHSUL4l QH4R5hSnXKGkXBJEiKpqBh3YHy2/0WA= X-Google-Smtp-Source: ABdhPJzC4UNgJPcmjhFOsSA7QnFjcELn7uW9/rMntfT0R0UVYMA9OxKubLKxHHNzjAUBz6moGh0FdQ== X-Received: by 2002:ac8:434d:: with SMTP id a13mr3760947qtn.91.1633184163843; Sat, 02 Oct 2021 07:16:03 -0700 (PDT) Received: from arch ([2601:82:c200:166d:afae:ebe6:a0e2:409e]) by smtp.gmail.com with ESMTPSA id a17sm5367433qtn.86.2021.10.02.07.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Oct 2021 07:16:02 -0700 (PDT) References: <87h7e1kebb.fsf@gmail.com> <87fstkoxfs.fsf@gnu.org> User-agent: mu4e 1.7.0; emacs 28.0.50 From: No Wayman To: Bastien Subject: Re: [BUG] [PATCH] org-src.el: Fix checkdoc warnings [9.5 (9.5-g59cb39 @ /home/n/.emacs.d/straight/build/org/)] Date: Sat, 02 Oct 2021 10:10:43 -0400 In-reply-to: <87fstkoxfs.fsf@gnu.org> Message-ID: <87zgrrv7fi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::82b; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qt1-x82b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633184330; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qURG6ZoYvyqevL/gbWVsWI1KLFdmMnRZ9QY2kTQJhlU=; b=ifrz5rbVBsjy5VkdkhVSm7Oiyii516jjWO3ickmVVlniEZ1IQqUCQN/fX1aamgW8c9Mc5o PW4RCNCsoRZX+jEKR7Me8tV0/paEBSh3jI8RTNhppPu3wHeoWWhDKQhvtPd3USpVdBtjTI sd5Q3jBQc7FBYQkr26JFsmVZiuYlOacG3xes0pjelIbYJGMfSNfA+fURxG+nUUAzTBJqiI ++w67kuOfgjQWPpjev7iqTanumHtMcg6Ht18+n5B4oo5+WROiigMkMXXq/cgQvmmVuMFkt 52Fm7w8hVgDxsb0UUUtFs1Jo1Pt58/POSzuhpmH85/G+e8S7i8aLFVGSRGzEgw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633184330; a=rsa-sha256; cv=none; b=JnneWHQu35FlpSOy6M27+4n3fQGwI9ROkpc/xcuRt3DwivzvdM+AOd6hoZxnS60tg2mkd8 BrmAmAepzofj4uLQ0o1iMc//gAS8bgTKMLY/RvTStXP7v0iIBMnLbFqvgx8add1KhFUGCi oY7J8tWIsMZeN/87z37O+9Gy2xDSk6dRmgKsbjfDMQ0BV5bmJ9+f6NQD+eGk+aC8JYzjDy VCKczEo4YIICqssGban+j0sV61/rDS7Nmn0/c3KcXiagIx/7FnhCOdO4e1zaFdyXoCMnnF jp5JmOyIHwWKlCkxIvJDbx0fcqYgQMyor+D/tlnOb028kv7/f8CRt0toy14BAg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Wapx3LIu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.10 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Wapx3LIu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 4670F2EA90 X-Spam-Score: -3.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: xdIejhleD1Mb --=-=-= Content-Type: text/plain; format=flowed Bastien writes: > Hi, > > No Wayman writes: > >> The attached patch > > I don't see a patch, can you resend it? Apologies. Resent. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-org-src.el-Fix-checkdoc-warnings.patch >From e5d1c6cc231363e20b378e082236af44ac717ccc Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Thu, 30 Sep 2021 16:07:15 -0400 Subject: [PATCH] org-src.el: Fix checkdoc warnings * org-src.el: Fix checkdoc warnings. --- lisp/org-src.el | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/lisp/org-src.el b/lisp/org-src.el index 0e16e236b..8f1e68d90 100644 --- a/lisp/org-src.el +++ b/lisp/org-src.el @@ -37,6 +37,7 @@ (require 'org-compat) (require 'org-keys) +(declare-function org--get-expected-indentation "org" (element contentsp)) (declare-function org-mode "org" ()) (declare-function org-element-at-point "org-element" ()) (declare-function org-element-class "org-element" (datum &optional parent)) @@ -239,8 +240,7 @@ green, respectability. :package-version '(Org . "9.0")) (defcustom org-src-tab-acts-natively t - "If non-nil, the effect of TAB in a code block is as if it were -issued in the language major mode buffer." + "If non-nil, TAB uses the language's major-mode binding in code blocks." :type 'boolean :package-version '(Org . "9.4") :group 'org-babel) @@ -303,7 +303,8 @@ is 0.") (put 'org-src--preserve-blank-line 'permanent-local t) (defun org-src--construct-edit-buffer-name (org-buffer-name lang) - "Construct the buffer name for a source editing buffer." + "Construct the buffer name for a source editing buffer. +Format is \"*Org Src ORG-BUFFER-NAME [ LANG ]*\"." (concat "*Org Src " org-buffer-name "[ " lang " ]*")) (defun org-src--edit-buffer (beg end) @@ -613,7 +614,7 @@ Leave point in edit buffer." ;;; Fontification of source blocks (defun org-src-font-lock-fontify-block (lang start end) - "Fontify code block. + "Fontify code block between START and END using LANG's syntax. This function is called by Emacs' automatic fontification, as long as `org-src-fontify-natively' is non-nil." (let ((lang-mode (org-src-get-lang-mode lang))) @@ -759,7 +760,9 @@ See also `org-src-mode-hook'." ;;; Babel related functions (defun org-src-associate-babel-session (info) - "Associate edit buffer with comint session." + "Associate edit buffer with comint session. +INFO should be a list simlar in format to the return value of +`org-babel-get-src-block-info'." (interactive) (let ((session (cdr (assq :session (nth 2 info))))) (and session (not (string= session "none")) @@ -769,6 +772,7 @@ See also `org-src-mode-hook'." (and (fboundp f) (funcall f session)))))) (defun org-src-babel-configure-edit-buffer () + "Configure src editing buffer." (when org-src--babel-info (org-src-associate-babel-session org-src--babel-info))) @@ -841,6 +845,7 @@ Raise an error when current buffer is not a source editing buffer." org-src--source-type) (defun org-src-switch-to-buffer (buffer context) + "Switch to BUFFER considering CONTEXT and `org-src-window-setup'." (pcase org-src-window-setup (`plain (when (eq context 'exit) (quit-restore-window)) @@ -1203,11 +1208,12 @@ the area in the Org mode buffer." (interactive) (let (org-src--allow-write-back) (org-edit-src-exit))) -(defun org-edit-src-continue (e) +(defun org-edit-src-continue (event) "Unconditionally return to buffer editing area under point. -Throw an error if there is no such buffer." +Throw an error if there is no such buffer. +EVENT is passed to `mouse-set-point'." (interactive "e") - (mouse-set-point e) + (mouse-set-point event) (let ((buf (get-char-property (point) 'edit-buffer))) (if buf (org-src-switch-to-buffer buf 'continue) (user-error "No sub-editing buffer for area at point")))) -- 2.33.0 --=-=-=--