From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +NxNCvXWRWOljgAAbAwnHQ (envelope-from ) for ; Tue, 11 Oct 2022 22:49:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CANjCvXWRWN/CAAA9RJhRA (envelope-from ) for ; Tue, 11 Oct 2022 22:49:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 60FCD11F80 for ; Tue, 11 Oct 2022 22:45:08 +0200 (CEST) Received: from localhost ([::1]:43016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiM7f-0000O9-CP for larch@yhetil.org; Tue, 11 Oct 2022 16:45:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiLqb-0007MN-BI for emacs-orgmode@gnu.org; Tue, 11 Oct 2022 16:27:29 -0400 Received: from forward105o.mail.yandex.net ([37.140.190.183]:55048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiLqW-0006zy-Sy for emacs-orgmode@gnu.org; Tue, 11 Oct 2022 16:27:27 -0400 Received: from forward502o.mail.yandex.net (forward502o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::612]) by forward105o.mail.yandex.net (Yandex) with ESMTP id 6CAD14C6AB7; Tue, 11 Oct 2022 23:24:02 +0300 (MSK) Received: from myt5-89cdf5c4a3a5.qloud-c.yandex.net (myt5-89cdf5c4a3a5.qloud-c.yandex.net [IPv6:2a02:6b8:c12:289b:0:640:89cd:f5c4]) by forward502o.mail.yandex.net (Yandex) with ESMTP id B3A2125D44CC; Tue, 11 Oct 2022 23:22:39 +0300 (MSK) Received: by myt5-89cdf5c4a3a5.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id 1GrJzueZbZ-MchefC09; Tue, 11 Oct 2022 23:22:38 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.com; s=mail; t=1665519758; bh=RczhFf2ms4f5rrgmLOglCJm2/1XuqHjaidSqBHp+IZY=; h=Message-ID:References:Date:Reply-To:Cc:In-Reply-To:Subject:To: From; b=MmBikIQFeLBpxPPN9KOR4CwmtxREG4TfLQxO9VXvIKXHuTtYUPtIZF9oHLCPwpKbb Y8YvPK/OOn11jmfA1ohnla96ZkEy945NVQZJqcghYPIDUABd24GKwR+oTORxIpMHxW ouJGVaVnt81jhrzOVwp37ki4sw7PjrmPySkAImb0= From: Colin Baxter To: Morgan Smith Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Org Habit fix + new feature In-Reply-To: (Morgan Smith's message of "Tue, 11 Oct 2022 12:39:51 -0400") References: X-Face: BHjiJOg/Qmj'BQgsAKL@])L)e62P)C"Y=6T Date: Tue, 11 Oct 2022 21:22:36 +0100 Message-ID: <87zge29kkz.fsf@yandex.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAAEkAAAATAgMAAAChCMjeAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEX/zAABCWP///8I RHjYAAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB+UFEAk5BvqS634A AAAbSURBVBjTY2BgCA1hYA0FAxDDgQEERsXoIAYA2F9Eb3cpB+AAAAAldEVYdGRhdGU6Y3JlYXRl ADIwMjEtMDUtMTZUMTA6NTY6MTcrMDE6MDCh/kkpAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA1 LTE2VDA5OjU3OjA2KzAxOjAwTyZ6HwAAAABJRU5ErkJggg== MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=37.140.190.183; envelope-from=m43cap@yandex.com; helo=forward105o.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: m43cap@yandex.com Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665521108; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RczhFf2ms4f5rrgmLOglCJm2/1XuqHjaidSqBHp+IZY=; b=Dds08ACNrpNGXrAYDBKLRi3UYFPq1SlKyCkfmle2j0/Yc3yE4R7avEuJo1/iTWh6yt+zUF RCZRM+MYtPLprFHlq91HsUvXBU18XLf3rxDpkuj7TaY545tlPeab0i3uY3PhHtkvxd/wi9 b/lJ4zk8/oMDnc61e2BOj1MFgs1MVW2wdzhkQYDgTk4JO9h+Jgx6kdu1ELmlDoWYo6usI6 Kn5a5zVtPmBcrClCHYN1DlpSVeGTTgKyp6yoS/1buL9/qDGJRxCf5DlTMfHMLvwm0edrka tQZNJmbZZkL2VTp4l/JHGuj6Godaxk124T0XorHE96glnTsZ/GE7WpP/nEFnzg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665521108; a=rsa-sha256; cv=none; b=TjB76dHJ2NJXEwIxVkyuX/qg8HiStNuSYNGk3irHG6aTXsXDxqDCOc7XdtGqs9fgINEZSW g+QMYQRATlanr3RGrBT3ux1QL9hCzItpgtyyqNfJhX9KWP3otCYiwbkNdfKM0IxvgslU6x GThAPxNe367DwbOOgyRdiB65VoPrPQ+ov0y8n9XMZ5qnQk8IXCzO3/dXmuNWF1jeI1qexC h+QkyYZLsscG7Z5EdYY8HbN/GG1gjMuWcxC+Yq8qz1GULeo87LmwR0mcVpBVlyHgC2FqqN nb+MfqrRdozrFfqmVTSC8u3o3BG2nufQBRBofWyZgFGzUgw3EUlk9/UM+kWTWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=yandex.com header.s=mail header.b=MmBikIQF; dmarc=pass (policy=none) header.from=yandex.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -9.39 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=yandex.com header.s=mail header.b=MmBikIQF; dmarc=pass (policy=none) header.from=yandex.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 60FCD11F80 X-Spam-Score: -9.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: TieAtNTmm9hH >>>>> Morgan Smith writes: > Hello! There are two patches here. The first one is a simple bug > fix that doesn't really have anything to do with the second patch. > It just happens to be in the same spot of the code. > The second patch allows a habit to be considered done if time was > logged to it. Imagine you have an org habit like shaving. > Chances are, if you spend time doing it, it's done. I like to set > LOGGING to nil for these kinds of habits since it's redundant to > have all those state changes that tell me exactly what the logbook > already tells me. Please do not alter the default behaviour. When writing a paper or a book I use and need both logging and state changes, and I would prefer not to have to spend time changing my setup.