From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GPo6Elo9xWMn0AAAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 13:04:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iDs0Elo9xWMYMgEA9RJhRA (envelope-from ) for ; Mon, 16 Jan 2023 13:04:42 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D1EDEC4D3 for ; Mon, 16 Jan 2023 13:04:41 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHODL-0007Ax-N3; Mon, 16 Jan 2023 07:03:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHODI-0007Ak-MS for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 07:03:45 -0500 Received: from mout-p-103.mailbox.org ([2001:67c:2050:0:465::103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pHODG-0005jj-L0 for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 07:03:44 -0500 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4NwVzX3Kjfz9skF; Mon, 16 Jan 2023 13:03:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kraus.my; s=MBO0001; t=1673870616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mcLAQoiqIF3UM9CCx6tB8Oa65rr4/eBOsVUNLUPcCzI=; b=CIzJjtfaHzz0H96IWfs0R6e7TiktJr2LfJ5oCg9wPp6DvWoeAMGG7WTYV7XyOZVGev+J6S r0UmwZvxCcAl8f3nKrnTPHfeVHGWzKAsnXRQ1FtqMmSMz/wMnYLOdIHPp58SoJ6wheQ4w3 EYJMReqediGXLG47A3XPVmUepNmeVcX4n+qbGN4lIansG5VK+bk16TX21g0dZTcveqPj3d CuDwrThTLYzwJ7z0Y1n+GhlRoYSpKQb37UfOf7TJYdkVTBDrpp9yN/BkN4gywTrxv2Eq4R nJMJ5R938XAEpssMBt+67G64FfvhVewnG3/5jtWCTm73rZIYKOXLuJaO15sHow== References: <874jsqbvfq.fsf@kraus.my> <87358an35i.fsf@localhost> From: Daniel Kraus To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-sql: Add support for Athena Date: Mon, 16 Jan 2023 12:52:40 +0100 In-reply-to: <87358an35i.fsf@localhost> Message-ID: <87zgaiadpx.fsf@kraus.my> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4NwVzX3Kjfz9skF Received-SPF: none client-ip=2001:67c:2050:0:465::103; envelope-from=daniel@kraus.my; helo=mout-p-103.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kraus.my header.s=MBO0001 header.b=CIzJjtfa; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673870682; a=rsa-sha256; cv=none; b=b8k1yXXbh4miEHQWARad1vdmhH7F1Yn8MUsnDGC+VA2W5JyIpoBk/mfWNWupg8DqNprqMN IxDY0L8NmJV2mqW7pkYU1DBbLxPb/X0OemEt8BTkMP+5D3xKO++osZW8WmdzCOEBR1nG8X OTFb2i8XnK4FWHzSEXp+61kldSc+zRW5l+I0MrI1hOseRyNmTlfp4TzuvlX0dqHTS/ef4h TOtkJ9B9fS+2E1HPVlbKn0o8GTRqeNzBWSlx5+oIrZNXk/zS4IAD7/6X2cFaCJf5hFW9ue O15ibru8qrFuCr9u6GZKWPzrBbKaQ41lv4vaXFevKfRiChi+AGrkGQiLidCIgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673870682; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mcLAQoiqIF3UM9CCx6tB8Oa65rr4/eBOsVUNLUPcCzI=; b=islNmLMBrYghfBhisYTBv2KX7Nx4CYxY/qVyAB6Gc00FrRG36DNwyMeEH+LmEtKxfvD2Sy bLO6pKfISJvchpd/xh0FlkraK1R1p+1vCDLvGWsfsI/2tvljmX9E0LsF1vuMz8U8SyjJWY mGd2dVVQ10ayJ5IiBpCMo3xnAoQf8jzxxXfgm9kNUikH+1DfyCn15IN+lLcZSG9Cqjjc9u 7ofzxX4gsJxgt3EkpBoJssdo/GTXkjqt/zfbzaM0rVbhaKqs2YA+jiSvU0CqPKgZFfFYlh MV8ZBLtPCnxcIR5dKE4pXxlv5KM6djgUwShE0+2eZJGtwxBx6shuUQ/0Dlq8XQ== X-Migadu-Queue-Id: D1EDEC4D3 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kraus.my header.s=MBO0001 header.b=CIzJjtfa; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -11.17 X-Spam-Score: -11.17 X-TUID: C2zCQGXCyKYS Ihor Radchenko writes: > Daniel Kraus writes: > >> I'm using this patch since a few month that adds support >> for AWS Athena. >> The only thing that's maybe against adding it is that >> `athenacli` (https://github.com/dbcli/athenacli) is not an >> official AWS tool but just a Python script. >> >> What's the opinion on this? > > Is this something commonly used? Athena itself is very widely used. But everyone uses either the AWS Webinterface or connect with JDBC (DBeaver/Datagrip etc) to it. The Python tool doesn't seem so popular (only 200 GitHub stars), that's also my main reason for not adding it. > I see two main issues with the idea: > 1. I do not like the idea of adding all the possible CLI tools over > there in ad-hoc manner. It would be cleaner to provide a > customization to add various cli tools in a defcustom/defvar without > manually changing the functions. > > 2. I feel like it will be hard to maintain such unpopular clients. If > (1) is addressed + good automatic tests are implemented, things may > be acceptable for inclusion though. > > In summary, I am not against the idea of including a new sql cli, but we > should better provide a centralized API to do so and make sure that we > have test coverage, making sure that things are not broken in future, > when the original committer is gone and nobody else is left familiar > with specific obscure SQL client. Completely agree. If I look in `org-babel-execute:sql` `command` ( https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ob-sql.el#n256 ) I think it would make sense to somehow make all those commands customizeable and let users add their own commands. But that's obviously a bit more work. I'll see if I find time for it in the coming months. Thanks, Daniel