From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8GXGJAvK62NPWAAAbAwnHQ (envelope-from ) for ; Tue, 14 Feb 2023 18:51:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6BPMIwvK62NhUQAAG6o9tA (envelope-from ) for ; Tue, 14 Feb 2023 18:51:07 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CE73B143B7 for ; Tue, 14 Feb 2023 18:51:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRzRm-0007rn-SL; Tue, 14 Feb 2023 12:50:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRzRk-0007rf-97 for emacs-orgmode@gnu.org; Tue, 14 Feb 2023 12:50:28 -0500 Received: from mail-dm6nam12on2125.outbound.protection.outlook.com ([40.107.243.125] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRzRi-0000hw-F7 for emacs-orgmode@gnu.org; Tue, 14 Feb 2023 12:50:28 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B3THQUNxjrZHO9X4RDF+hx0ZuoL6Y8IL89DolZDhmrVTQ+CvmaX/kz32r5vVId/ukdl4snU28uchcezkuw2bZK9uezxwNYhRFhoY04TBkNm9+Q0uC89n4h7A7rh+jev9anyeoXjanjjR6z8ErpeRa2MDy/3+y8BRtSkL179htQC9zNIcNLChfa4DH/bk4WK6iM78ZGESjzhdK4mwytDn3crpFvh8OD+HyyoDFcHlRYdMLyYo4ezQUyaYv7RL1V3RPX/j3EIX4zBl64ZakqeM2A8O6vePPWIoPKYyzuwEoBovOf8tcqaxwB33n+uSmjezXvqPFV3yPwGHqAqjmZVKwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gMiQzLqXx1+lG2CUniqnYwhFOVsKAMkUFIh57s+uoEY=; b=isunDgqcnkAj3yO27Y2IwmdgpG2ISOSMKtf49mQljEADSp+BTtM20zUh6sQ+VOye2fdaeEojSMX10ubu7TVxWlCMWiMZfwhJKW9awVnTuU234K7iuL6EHscpGkmc962iQrncpdEBwtHN3JzNMxmciUcrKBhqbe2oKC795QZLvbme1pGubUJ2Z4ZIrgAr6szNbz0QfEhcE1E+IRXkvITT1tso92rtgWAV2T2BDYcjXg/5Z/gKpl2OKsyFWFS/BthP9C1orBZIZ9KlYJ9Im9fH0crAJidOyNyRpvJmz70D1a98uLYxQeOMqbBzPzMMEDHDgYQctHCSeXixbQzIZ2HkvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=umanitoba.ca; dmarc=pass action=none header.from=umanitoba.ca; dkim=pass header.d=umanitoba.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umanitoba.onmicrosoft.com; s=selector2-umanitoba-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gMiQzLqXx1+lG2CUniqnYwhFOVsKAMkUFIh57s+uoEY=; b=XW9YgALAnJIme6urO/HUImh0G87FJUA1DXXW9GCJOISBqNQ9TMwqGtC0oXrVG9hhtewNCNIN19Ssuh1pNaaleJY+S+V5eSlVwsApDu6TNqylPlHsGRpnStbezc4KrikJLYVGpZ44hybOmR1PRVto8WZ2HzoEZDIaJeRbJDFU2kI= Received: from YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:90::5) by YT4PR01MB10642.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:ee::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Tue, 14 Feb 2023 17:50:24 +0000 Received: from YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM ([fe80::4809:b686:dd5c:b1fd]) by YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM ([fe80::4809:b686:dd5c:b1fd%6]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 17:50:24 +0000 From: Leo Butler To: Max Nikulin CC: Org Mode Mailing List Subject: Re: [PATCH] remove unused code in ob-octave.el Thread-Topic: [PATCH] remove unused code in ob-octave.el Thread-Index: AQHZPMx7wtP8Kty7pEGEeRzn3UQghQ== Date: Tue, 14 Feb 2023 17:50:24 +0000 Message-ID: <87zg9gqgps.fsf@t14.reltub.ca> References: <87sffetu09.fsf@t14.reltub.ca> In-Reply-To: (Max Nikulin's message of "Fri, 10 Feb 2023 09:32:05 +0700") Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YT3PR01MB9964:EE_|YT4PR01MB10642:EE_ x-ms-office365-filtering-correlation-id: c64aafe6-7565-4efa-a981-08db0eb3f2ee x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uVEeJGkU28s+SkyrC4evpvoSQiwaabxQfjT6H7a/b+EXv6ESpXXTAX/g/o44USwcJoNndebl/wsrerCDioFJ4wSrEv7p6lKlSNcNCx+/9k1Hd/CbtssbEWnE3D2ilVlSFhJMQfrkscvnGaD6nQNXXDxy0dgWIf4coqLnsV3JuRMWQRYBC1pEMVAfdShHkI1Efi7WhCxeC8Ww19k58zRX6ctxehQKSSVqxS05t2zDsxE1ixYe80ZzkLNrxVDJ3BnGoFYT0PAQA0Bbkp4hbS3gYwX/OqKpgritDgwegRFbkXFbza+Wcv4SLX76x//W9z+OOfWgShnsBazhpm6VyAbU17VAtWth7szuUZBpEcdIUJGosTG6FPu8+JHsCG+SNPDTbdozFsrr2JHR3+nw08zIWLPWjWe47n0TfR9+O+lOuEmwvBFRRf4TXNX8puiEa17v7P6v4w0JScRBsbcivg4wWwbmigW//Tl1tGq2yzUStBJXop+lNNllPKma5EmpogfPeRL5S1UhwqaGZd5iXueCaOoVwB9Hx+fRWHi66il/EvhRgH1q9H2O0wsWYNl8U3CD3tAHSBh3vlUIcPlgxYoe6H9EvrqE2ItKByeOHJchYHU0bTj4jbdU31ednmhYrB9Tj8gjYPUfJkwLNZV7gmmeIcPV024os3x2WsvLlfOVptLqHD+QqNITFvweTrQbHRO9/+9Utwbl+j9qIy/L+OHSlA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230025)(136003)(396003)(39860400002)(346002)(366004)(376002)(451199018)(478600001)(2906002)(26005)(6512007)(9686003)(53546011)(6506007)(186003)(38100700002)(71200400001)(6486002)(8936002)(86362001)(38070700005)(786003)(122000001)(316002)(5660300002)(6916009)(66446008)(64756008)(66476007)(66556008)(41300700001)(76116006)(4326008)(8676002)(66946007)(91956017)(41320700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?dnFo2ePZtAcC7GUpRyJnD0d3SltUxfIcVYb6hw2G6oZF+3AmjzqGarmlJO?= =?iso-8859-1?Q?cjC11lh4Rfi5QSQHY+XUNACZnPgL6BTvaPzoR22SyabNHWYHWqhQT1KQd3?= =?iso-8859-1?Q?+tUbqiIXfhBg4ruPGcQ0a3I9Gr+Pf4qXzENEVKE+8sjw8g5d+5X0gvDdg3?= =?iso-8859-1?Q?0stMJ74Dx9v2XEoYThAgKED7z2xPJ5V/c3aP5SbcnYYgitEGiAdfYJ3Xna?= =?iso-8859-1?Q?NSIc4LMHpD4wz2NUBnZKImZbZHDgsD4iPC/KAtXJYm39OcNX9rWBttO8fT?= =?iso-8859-1?Q?THYfTbKAjpcWRlphNeViZS8FBpcn6qg6XES8if8rSItKyN4NSkwBjJSQB0?= =?iso-8859-1?Q?JP5PYQMET7cMoiUbCFyCF4spaOgcw8tMVLAhs7/YI2E6Kkb04FiDJNDCqV?= =?iso-8859-1?Q?t9TW0R1k5h80HeqP8WfsaHpeXGceXc1kVfzq6UC0q+dfNVCRxoR2CxXXRz?= =?iso-8859-1?Q?SU9agA6XD/EsXnIr51kxmk33r1yroOLpQtpEvUdHqidCCIo4hAw6OOQetU?= =?iso-8859-1?Q?MY6NEybKK0JMX2iELeA3QD9bIYPWGBbFFA0TP65FqRW1DEjU9e77/zAfAm?= =?iso-8859-1?Q?JLk9khoU5MEx+BkZ8oo9iPUwKHLQbETVx1wqjrmcVOb+pwT21VVuYIZP3g?= =?iso-8859-1?Q?cyjQv3RawLRPxNygBotaiNoneHprQv7SAYn743XF+qEWOB3//ZnILn2o+4?= =?iso-8859-1?Q?B19W5ZoUnTTxMhjeTqlKwD5qwl5j/4DLSCcYxFAdwf3cHF28K9KRUjPlRf?= =?iso-8859-1?Q?r2qErqYs39owU6PG5OBVrS7qt5OzvXqJ3doGbfjxqWuC44wLlTJIRMqzIg?= =?iso-8859-1?Q?axDQKF9b6cwTZmywILnVR7cAM8OxxrX4x1/2DjVh22ZmJUabyLSlihkxU7?= =?iso-8859-1?Q?SqvNW5X4gqNqPFHXL/86FE/a3ChbBJ7MsQc2Xc5NCXHMaHYCmuaRhKUXYR?= =?iso-8859-1?Q?Lm3p0Z16lFjM2utNfq+7LgW1TkR9xMQJ5r/k6+yqGyzH/RY2yZTD6TsqtR?= =?iso-8859-1?Q?KZXOoof1/DXR7S6Ft+B+RlD0EaAN8Sq4X0LPNolIPVGr6rLx1s6d+jGH6v?= =?iso-8859-1?Q?xiAe/4NarSqYfiH7iB46+VyttUrQ+alyYVlQPtH1ajjux+8PFf3zfqVxqH?= =?iso-8859-1?Q?pL+qrjF7CDEVsAvKlF8FAvunLKzNRCbAVC54/0Ks5gRkVeyLK4UMNf4X/5?= =?iso-8859-1?Q?UCa7+MfunBw2J89yhO/KZvpoxmVBsuWilXoD7gP44u786NJGafyhiO4DZM?= =?iso-8859-1?Q?x044P1y9cdcDgi0yb1394eFDcrXgHu0gg59hgs8BehnGdDmiV7hRCXz+9e?= =?iso-8859-1?Q?M1SASgSZ00WQXEy+EDkb1qnX9msOH9q9bndbeHKn86N4x+m35mWt2W/8E8?= =?iso-8859-1?Q?aN3aUzURl63gkhDNpiiqQW14nXMwFEyfi1DqTXdiuzA14W454kGdZ9EJaz?= =?iso-8859-1?Q?hwGvCeGIislpgZlGkSCqiTqVwX3O7KXWKnoixq+w7mfyz4ZtMvbZdeEF2Y?= =?iso-8859-1?Q?quzBUvKFlsb890bL4bLhR5guVf97osGDWhdnOUonKULqdLWe40jrGWR0Dz?= =?iso-8859-1?Q?7WlXdAt/Xwvg4yzsS75yaN3TqQnNdXzd4TIPAe/EGeoaVt0XMT1XrBTzc5?= =?iso-8859-1?Q?IygZFJMzEDCcFOFx2NbpqUNfYSZopPB1GXry4IdwKjNmqcROHoD2JIkw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: umanitoba.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB9964.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: c64aafe6-7565-4efa-a981-08db0eb3f2ee X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2023 17:50:24.0250 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4f80dd0b-338c-4e4c-8a14-90446962f7b8 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2l4lsgjqPTrq5Npvl2ATHdso2Mlww+BNdItldFjAB75mLNUcSgA4AdLNwxmO0FyImFwMyp8bU1mw6HVdHdLXQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT4PR01MB10642 Received-SPF: pass client-ip=40.107.243.125; envelope-from=Leo.Butler@umanitoba.ca; helo=NAM12-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=2; s=key1; d=yhetil.org; t=1676397067; a=rsa-sha256; cv=pass; b=isiGPsJDG3q0W969z0KSkWBYDtmDkeRg2Y8wjOURcAqSNH/LtZOymm/9AXOdiGq9sq077C bLxLhKAC4/PVthaPIqx3Q08P6ulSbdh5i156Th41BsaMR6nd6c2W64cB+EC65Fyw4q+gVo M1k/2onoTPXzkvT8yhWuJSMw4JNtIdYZgyKPVhwieIU+Bk+SGcAG3Zyy7YgRKm8N1pMxwp J7GKA5/PbVj/mhK+RkAxN7e7asQc/cV1E7ZjR1DyWgyuQAhOEcien8KvAcJb1cCHfgYvgC Ku12rxdNBquS3N21APW2pFcWokiMST1TLf/C/JCk/NzqdTiBVFYWyGuVXr35CQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=umanitoba.onmicrosoft.com header.s=selector2-umanitoba-onmicrosoft-com header.b=XW9YgALA; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676397067; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=gMiQzLqXx1+lG2CUniqnYwhFOVsKAMkUFIh57s+uoEY=; b=KBd5pSGDXjkeXVxHZs4+GZq2UsP93vtvMZIa7AjGE5aTXE66Yp2qeWxXtZKzkpnPBIZIhj S3uEyllFMDMF8kLy80sf4Fl0WPCkxAinzy45o2vrmfqk6W1hnUPfmNHELQJ0V1Zfx/rzYs El/L7nsnftJr7IuLAmHrXivcjd8PtO/bDihOsfzvuXv1icXvSbwo+PICFuIW3/XiYu17tM s0pFMgsGmzwa+0yuS/pJCtoWvYYAdWl2bBBh+mtCOVFM7DgRlDKcGQxJuyi5Fk0F54oMq1 2/I04hwyMEJ3IRaJPnNjUqpT0WVzDb6fNxSxVDrd6xL/VVTCtAzrVTmLSsFjIQ== X-Spam-Score: -5.37 X-Migadu-Queue-Id: CE73B143B7 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=umanitoba.onmicrosoft.com header.s=selector2-umanitoba-onmicrosoft-com header.b=XW9YgALA; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Migadu-Spam-Score: -5.37 X-TUID: kqto4jwg6GO5 On Fri, Feb 10 2023, Max Nikulin wrote: > On 10/02/2023 04:21, Leo Butler wrote: >> In lisp/ob-octave.el: >> What is the point of ob-octave-prep-session:octave or its brother, >> ob-octave-prep-session:matlab? >> These two functions are unused in the existing code. > > Have you checked the following? I am not familiar with org-babel code. > > grep -nH org-babel-prep-session lisp/ob-core.el > lisp/ob-core.el:1041: (prep-cmd (intern (concat > "org-babel-prep-session:" lang)))) > lisp/ob-core.el:1050: (error "No org-babel-prep-session function for > %s!" lang)) > > Do test passes when you patch is applied? It might mean that test > coverage is not perfect. Yes, the tests pass after removing the code. I can see from your and Ihor's response that my suggestion is wrongheaded.=20 After looking more carefully at ob-core, I am not sure how I could write a test for the prep-session code, though. The comment and docstring in ob-template.el does not help me, I am afraid. And the existing session-related tests do not touch the prep-session code. I'll poke around in other ob-*.el code and see if I can figure it out. Leo=